https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422017-10-09T20:39:28ZArvadosArvados - Bug #12418: [CWL] Crash with glob on empty collectionhttps://dev.arvados.org/issues/12418?journal_id=558102017-10-09T20:39:28ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/55810/diff?detail_id=53533">diff</a>)</li></ul> Arvados - Bug #12418: [CWL] Crash with glob on empty collectionhttps://dev.arvados.org/issues/12418?journal_id=558132017-10-09T21:16:33ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/55813/diff?detail_id=53535">diff</a>)</li></ul> Arvados - Bug #12418: [CWL] Crash with glob on empty collectionhttps://dev.arvados.org/issues/12418?journal_id=558142017-10-09T21:29:23ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>Assigned To</strong> set to <i>Peter Amstutz</i></li><li><strong>Target version</strong> set to <i>2017-10-11 Sprint</i></li></ul><p>This is believe to be the underlying cause of the failures in <a class="external" href="https://projects.veritasgenetics.com/issues/3775">https://projects.veritasgenetics.com/issues/3775</a></p> Arvados - Bug #12418: [CWL] Crash with glob on empty collectionhttps://dev.arvados.org/issues/12418?journal_id=558192017-10-10T13:14:08ZBryan Coscabcosca@curii.com
<ul></ul><p>This is blocking me here: <a class="external" href="https://projects.veritasgenetics.com/issues/2968">https://projects.veritasgenetics.com/issues/2968</a></p>
<p>Also, I added the link to 12323, I posted this error before there.</p> Arvados - Bug #12418: [CWL] Crash with glob on empty collectionhttps://dev.arvados.org/issues/12418?journal_id=558202017-10-10T13:16:40ZTom Morristfmorris@veritasgenetics.com
<ul></ul><p>This is also blocking another four production batches, VGX1991-VGX1994.</p>
<p><a class="external" href="https://projects.veritasgenetics.com/issues/3773">https://projects.veritasgenetics.com/issues/3773</a></p> Arvados - Bug #12418: [CWL] Crash with glob on empty collectionhttps://dev.arvados.org/issues/12418?journal_id=558302017-10-10T15:45:34ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>12418-glob-empty-collection @ <a class="changeset" title="12418: Explicitly check if collection is not None The empty collection evaluates to False, so it..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/250f1578314d1f4d053d3d9f65a3d5c33d1578af">250f1578314d1f4d053d3d9f65a3d5c33d1578af</a></p>
<p>Use "collection is not None" instead of just "if collection", because the empty collection should evaluate to False.</p>
<p>Strangely, when I tried this in the virtualenv I usually use for development, the empty collection evaluated to True. But in other environments, it evaluates to False (this behavior is more consistent with the documented behavior).</p>
<p>Disassembling the <i>nonzero</i> function indicates that it is failing to check <i>len</i> like it is supposed to in that environment. However it does it correctly in other environments. So this seems to be a Python bug in the particular version in this particular virtualenv (???)</p> Arvados - Bug #12418: [CWL] Crash with glob on empty collectionhttps://dev.arvados.org/issues/12418?journal_id=558442017-10-10T17:47:03ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>This LGTM, local test run finished ok. Thanks.</p> Arvados - Bug #12418: [CWL] Crash with glob on empty collectionhttps://dev.arvados.org/issues/12418?journal_id=558472017-10-10T18:10:06ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset arvados|commit:0bb435a47e427b12fa2351141a22a1ba1e28a49d.</p>