https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422017-10-19T17:38:42ZArvadosArvados - Bug #12467: crunch-run not waiting for Docker image to finish loading.https://dev.arvados.org/issues/12467?journal_id=561262017-10-19T17:38:42ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/56126/diff?detail_id=53789">diff</a>)</li></ul> Arvados - Bug #12467: crunch-run not waiting for Docker image to finish loading.https://dev.arvados.org/issues/12467?journal_id=561272017-10-19T17:41:13ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>Assigned To</strong> set to <i>Peter Amstutz</i></li></ul><p>12467-read-imgload-response @ <a class="changeset" title="12467: Wait for response that image loading is complete Need to do this before trying to start c..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/d64215e8f0057cc7b4c6295932bc7f44d27a1eb5">d64215e8f0057cc7b4c6295932bc7f44d27a1eb5</a></p> Arvados - Bug #12467: crunch-run not waiting for Docker image to finish loading.https://dev.arvados.org/issues/12467?journal_id=561302017-10-19T17:53:04ZTom Cleggtom@curii.com
<ul></ul><p>Better form to do "defer response.Body.Close()" before ioutil.ReadAll(), so it gets closed even if read fails.</p>
<p>I think the error message has copy-paste-itis: "While reading response to container image into Docker: %v"</p>
<p>I'm guessing it means "error reading response from docker.ImageLoad: %v"</p>
<p>You don't need to say string(rbody) -- %s prints a []byte as a string.</p> Arvados - Bug #12467: crunch-run not waiting for Docker image to finish loading.https://dev.arvados.org/issues/12467?journal_id=561312017-10-19T18:04:35ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Tom Clegg wrote:</p>
<blockquote>
<p>Better form to do "defer response.Body.Close()" before ioutil.ReadAll(), so it gets closed even if read fails.</p>
<p>I think the error message has copy-paste-itis: "While reading response to container image into Docker: %v"</p>
<p>I'm guessing it means "error reading response from docker.ImageLoad: %v"</p>
<p>You don't need to say string(rbody) -- %s prints a []byte as a string.</p>
</blockquote>
<p>All fixed, plus a bonus fix log.Printf -> runner.CrunchLog.Printf</p>
<p>12467-read-imgload-response @ <a class="changeset" title="12467: Fix log messages. Defer response.Body.Close(). Arvados-DCO-1.1-Signed-off-by: Peter Amst..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/a976b02dc7ecba18277aceeaf086ab76fe4bf3f0">a976b02dc7ecba18277aceeaf086ab76fe4bf3f0</a></p> Arvados - Bug #12467: crunch-run not waiting for Docker image to finish loading.https://dev.arvados.org/issues/12467?journal_id=561352017-10-19T18:08:52ZTom Cleggtom@curii.com
<ul></ul><p>LGTM</p> Arvados - Bug #12467: crunch-run not waiting for Docker image to finish loading.https://dev.arvados.org/issues/12467?journal_id=561362017-10-19T18:15:05ZAnonymous
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset arvados|commit:6fd6ddcebda57df4ecb2303dc229420c2c13af7b.</p>