Project

General

Profile

Actions

Bug #12475

closed

keepproxy panic: send on closed channel

Added by Joshua Randall over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Keep
Target version:
Story points:
-

Description

Our keepproxy crashes when we try to run a heavy workload on it (consisting of 40 clients each of which does an arv-put followed by an arv-get to verify md5). It is currently running on an instance with 4 cores and 16GB of RAM, which is very low for this workload, but I don't think we should expect keepproxy to panic in this situation.

Here is the end of keepproxy output during one of these panics (it seems to do it within a few minutes of starting up this workload):

2017/10/22 19:20:03 172.17.125.24:37929 GET /a84821554454fe8f7596caaf9a61cccd+67108864+Aed63b730e725c629b40e07e553eaf37933256698@59ff62cf 200 67108864 67108864 http://arvados-keep1-ncucu.node.delta-hgiarvados.consul:25107/a84821554454fe8f7596caaf9a61cccd+67108864+Aed63b730e725c629b40e07e553eaf37933256698@59ff62cf <nil>
2017/10/22 19:20:03 172.17.125.24:39898 GET /94b41e42d11131cb972797d1e6fff08d+67108864+A6949359fcffe7369baffbbf6c756785b1ebee296@59ff6388 200 67108864 67108864 http://arvados-keep1-ncucu.node.delta-hgiarvados.consul:25107/94b41e42d11131cb972797d1e6fff08d+67108864+A6949359fcffe7369baffbbf6c756785b1ebee296@59ff6388 <nil>
2017/10/22 19:20:04 172.17.125.20:58495 GET /bcdf290b01a8cb009863b7a7f7c5aa1a+67108864+A69da494c07a84ae0a7aa5b22313fb7755878311a@59ff63ab 200 67108864 67108864 http://arvados-keep0-ncucu.node.delta-hgiarvados.consul:25107/bcdf290b01a8cb009863b7a7f7c5aa1a+67108864+A69da494c07a84ae0a7aa5b22313fb7755878311a@59ff63ab <nil>
2017/10/22 19:20:04 172.17.125.24:38643 GET /46367ef0ae85032ddddf2b09bb1c9279+67108864+A2009776510367dd137fce6a786b656a2c977da39@59ff6314 200 67108864 67108864 http://arvados-keep1-ncucu.node.delta-hgiarvados.consul:25107/46367ef0ae85032ddddf2b09bb1c9279+67108864+A2009776510367dd137fce6a786b656a2c977da39@59ff6314 <nil>
2017/10/22 19:20:04 172.17.125.20:57082 PUT /b6bb371abd73e72268e143a3be0bc685 200 67108864 2 3 b6bb371abd73e72268e143a3be0bc685+67108864+Aaa372c94f2b2ad30d068737188ed7e63297ad7d8@59ff6464 <nil>
2017/10/22 19:20:04 172.17.125.17:43708 PUT /1fd14f1cf5f52b710c81053ea2570a2f 200 67108864 2 3 1fd14f1cf5f52b710c81053ea2570a2f+67108864+A0fb506e498ee15e1b2c06666e01f8aff28211a50@59ff6464 <nil>
2017/10/22 19:20:04 172.17.125.23:23723 GET /ade35c0b85f67985a43ce8058b3ffe4d+67108864+Adf1930a6d6e4bf5e971ec9a0f893393780eedd22@59ff630a 200 67108864 67108864 http://arvados-keep1-ncucu.node.delta-hgiarvados.consul:25107/ade35c0b85f67985a43ce8058b3ffe4d+67108864+Adf1930a6d6e4bf5e971ec9a0f893393780eedd22@59ff630a <nil>
2017/10/22 19:20:04 172.17.125.24:38216 PUT /5069a264a8766477da5ac90970b3254a 200 67108864 2 3 5069a264a8766477da5ac90970b3254a+67108864+A33c0a8e2dcad8580035ffa2ad71614db01aee537@59ff6464 <nil>
2017/10/22 19:20:04 172.17.125.17:43067 PUT /7f25b9337609917bd6c3af526fd9331b 200 67108864 2 3 7f25b9337609917bd6c3af526fd9331b+67108864+A51c536ee6ae0821af5156933ea6f4cf5a0ac3f34@59ff6464 <nil>
2017/10/22 19:20:05 172.17.125.24:41786 PUT /34ef3fccf17eef9b8c86246711ac00b6 200 67108864 2 3 34ef3fccf17eef9b8c86246711ac00b6+67108864+A76d706a3c52fe376585cc38490520728e23a9346@59ff6465 <nil>
panic: send on closed channel

goroutine 26589 [running]:
git.curoverse.com/arvados.git/sdk/go/streamer.handleReadRequest(0x0, 0xe98, 0xc4d097e660, 0xc5a0b00000, 0x4000000, 0x4000000, 0x0, 0x0, 0x0)
        /tmp/tmp.JuAvTIlWhz/src/git.curoverse.com/arvados.git/sdk/go/streamer/transfer.go:170 +0x218
git.curoverse.com/arvados.git/sdk/go/streamer.(*AsyncStream).transfer(0xc500aa8840, 0x8a6300, 0xc4a086f6e0)
        /tmp/tmp.JuAvTIlWhz/src/git.curoverse.com/arvados.git/sdk/go/streamer/transfer.go:244 +0x51d
created by git.curoverse.com/arvados.git/sdk/go/streamer.AsyncStreamFromReader
        /tmp/tmp.JuAvTIlWhz/src/git.curoverse.com/arvados.git/sdk/go/streamer/streamer.go:74 +0x1d0


Subtasks 1 (0 open1 closed)

Task #12583: Review 12475-asyncbufResolvedTom Clegg10/22/2017Actions
Actions

Also available in: Atom PDF