Project

General

Profile

Actions

Bug #12478

closed

[crunchstat-summary] bad time formatting for jobs > 24 hours

Added by Tom Morris over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
10/24/2017
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

The x-axis labeling for all graphs in the HTML output is wrong as the job passes the 24 hour mark:

20h50m0s
22h13m20s
23h36m40s
1d190000
1d295000
1d3100000

In addition to fixing the bug, it'd be nice to choose more intuitive intervals for the scale if not too much work. e.g. instead of 1h23m20s use 1h30m or just 1h


Files

example-10m.png (34.3 KB) example-10m.png Tom Clegg, 11/02/2017 05:59 PM

Subtasks 1 (0 open1 closed)

Task #12491: Review 12478-duration-fmtResolvedTom Morris10/24/2017

Actions
Actions #1

Updated by Tom Morris over 4 years ago

  • Target version changed from Arvados Future Sprints to 2017-11-08 Sprint
Actions #2

Updated by Tom Morris over 4 years ago

  • Assigned To set to Tom Clegg
Actions #4

Updated by Tom Clegg over 4 years ago

  • Status changed from New to In Progress
Actions #5

Updated by Tom Morris over 4 years ago

Looks great. I don't suppose you could be talked into creating a PR for the upstream too?

Actions #6

Updated by Tom Clegg over 4 years ago

Tom Morris wrote:

Looks great. I don't suppose you could be talked into creating a PR for the upstream too?

It could certainly be generalized a bit and turned into timeOffsetTicker. Probably would want it to work in milliseconds like the rest of the JS world. Not sure whether what I've done for our special case is close enough to the generalized version to justify going down the PR road...

Actions #7

Updated by Anonymous over 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:c4ac98db757e738431dbcde54ac738fb554e16e8.

Actions

Also available in: Atom PDF