Arvados

Current issues with repository browsing:

• Repositories are displayed under the heading "Local Files" which is wrong. Change the label or move "repositories" up one level in the tree
• It currently clones the repositories immediately when the "repositories" folder is expanded. This needs to change so that it only clones a repository when the user clicks on it
• When cloning a repository, the web app essentially freezes. If possible it should do more of the work as background tasks. It should also display a spinner to indicate something is happening.

Also, there needs to be a "refresh" button to re-read the contents of a repository.

• Indentation is off all over the place, maybe it’s just my editor that is configured incorrectly? Should I set it up in some way or maybe we should correct the indentation as it’s sometimes difficult to follow the code.
  • Further checking various modified files’ logs, it seems that the bad indentation commits started on early 2018, maybe it’s a good data point to find the issue. Do you see the indentation correctly on your machine?
• File composer/src/app/core/global/arvados-global.service.ts
  • Imports from lines 6, 7, 8, 9, 11, & 12 seem to be unnecessary
• When opening an app, the status bar shows a “Checking for app updates…” that’s not removed (don’t know if it does something) until closing the cwl file. It happened once to me that this message was still there after closing all files, couldn’t reproduce it again
• App name accepts something like ‘somename/other.cwl’, auto creating the ‘somename’ dir if it doesn’t exist. Don’t know if this is intended.

Repo refreshing worked OK on my tests.

Lucas Di Pentima wrote:

• Indentation is off all over the place, maybe it’s just my editor that is configured incorrectly? Should I set it up in some way or maybe we should correct the indentation as it’s sometimes difficult to follow the code.
  • Further checking various modified files’ logs, it seems that the bad indentation commits started on early 2018, maybe it’s a good data point to find the issue. Do you see the indentation correctly on your machine?

Sorry about that, my editor wasn't auto-converting tabs to spaces. I re-indented and re-saved all the affected files.

• File composer/src/app/core/global/arvados-global.service.ts
  • Imports from lines 6, 7, 8, 9, 11, & 12 seem to be unnecessary

Fixed.

• When opening an app, the status bar shows a “Checking for app updates…” that’s not removed (don’t know if it does something) until closing the cwl file. It happened once to me that this message was still there after closing all files, couldn’t reproduce it again

Thanks, I commented that out.

• App name accepts something like ‘somename/other.cwl’, auto creating the ‘somename’ dir if it doesn’t exist. Don’t know if this is intended.

Not intended, but if it is doing something reasonable I'm okay with it. Although now I wonder what happens if you try to create "." and ".." files, which would probably cause problems.

Repo refreshing worked OK on my tests.

I think this is feature complete now. Intended behavior of "synchronize" button (tested manually, you should too):

• Expanded folders remain expanded
• Double clicking on an updated (file, tool, workflow) displays the content from the most recent sync
• Open tabs displaying a (file, tool, workflow) which are not modified by the user are refreshed from latest sync
• Open tabs displaying a (file, tool, workflow) which have been modified by the user are left alone

The save button interacts with sync this way:

• When saving, commit and push. If this goes through, we have the latest version.
• If the upstream rejects the push, do a sync, then create a new commit on the new head (effectively a rebase) and try to push again.
• The sync behavior described above applies

Tried creating a new file with name '../../../hello.txt' and it created it and showed as '..' are valid subdir names. When pulling the repo on my computer I got a message like this:

$ git pull
WARNING: 'lucas/lucas4xphq' is an alias for '4xphq-s0uqq-1cqslhxvx2496fq'
remote: Counting objects: 15, done.
remote: Compressing objects: 100% (7/7), done.
Unpacking objects: 100% (15/15), done.
remote: Total 15 (delta 3), reused 0 (delta 0)
From git.4xphq.arvadosapi.com:lucas/lucas4xphq
   1808652..8c8141f  master     -> origin/master
Updating 1808652..8c8141f
error: Invalid path '../../../hello.txt'
Fast-forward
 ../../../hello.txt | 1 +
 test3.txt          | 4 ++++
 2 files changed, 5 insertions(+)
 create mode 100644 ../../../hello.txt
 create mode 100644 test3.txt

The result is that the file wasn't really created on my machine (not even on ../../../ path) and a delete operation is staged for commit. Maybe this should be filed as a separate bug.

More related to the sync feature, I found a strange behavior that may need some fixing:
1. Open composer and expand a repository with files
2. On the computer's clone, remove a file, commit & push
3. On composer double-click on the removed file that still exist on the sidebar: the sidebar will get updated but the file will be opened on a tab with its contents.
4. If the save button is pressed, it'll get re-committed.

Feedback from sprint review:

• If possible, notify to the user when saving over a remotely modified document
• When refreshing, could have dialog offering whether to save or revert document
• Refresh automatically by polling?