Bug #12558

[Workbench] Bad dashboard time formatting - 60m == 1h

Added by Tom Morris about 1 year ago. Updated 9 months ago.

Status:
New
Priority:
Normal
Assigned To:
-
Category:
-
Target version:
Start date:
11/06/2017
Due date:
% Done:

0%

Estimated time:
Story points:
-

Description

I saw this on the workbench dashboard:

Started at 9:17 AM 11/6/2017. Active for 3h60m.

It should instead be formatted as 4h.

History

#1 Updated by Tom Morris about 1 year ago

  • Target version changed from 2017-11-22 Sprint to Arvados Future Sprints

#2 Updated by Tom Clegg 9 months ago

in source:apps/workbench/app/helpers/pipeline_instances_helper.rb we do this after computing days/hours/minutes.

    if round_to_min and seconds >= 30
      minutes += 1
    end

Instead, before computing days/hours/minutes, we could do

    if round_to_min && duration >= 30
      duration += 30
    end

(Without the ≥30 test, adding 30 would cause duration==10 to be reported as "40s" when round_to_min is true.)

Also available in: Atom PDF