[Workbench] Bad dashboard time formatting - 60m == 1h
I saw this on the workbench dashboard:
Started at 9:17 AM 11/6/2017. Active for 3h60m.
It should instead be formatted as 4h.
#2 Updated by Tom Clegg over 1 year ago
in source:apps/workbench/app/helpers/pipeline_instances_helper.rb we do this after computing days/hours/minutes.
if round_to_min and seconds >= 30 minutes += 1 end
Instead, before computing days/hours/minutes, we could do
if round_to_min && duration >= 30 duration += 30 end
(Without the ≥30 test, adding 30 would cause duration==10 to be reported as "40s" when round_to_min is true.)