Bug #12731

[crunchstat-summary] zoom/pan should be synchronized for all HTML graphs

Added by Tom Morris almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Tom Morris
Category:
-
Target version:
Start date:
12/04/2017
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

Currently the four graphs in the HTML plot are zoomed and panned independently. This should be synchronized, locking the X axes together for all of them.

Example code available here: https://github.com/danvk/dygraphs/blob/master/src/extras/synchronizer.js


Subtasks

Task #12732: Review 12731-synchronized-graphsClosedTom Morris

Associated revisions

Revision 83bd8999
Added by Tom Morris almost 4 years ago

Merge branch '12731-synchronized-graphs' closes #12731

Arvados-DCO-1.1-Signed-off-by: Tom Morris <>

History

#1 Updated by Tom Morris almost 4 years ago

  • Status changed from New to In Progress

#2 Updated by Tom Clegg almost 4 years ago

at f24bdaa4b

Need to add synchronizer.js to MANIFEST.in (otherwise it doesn't get packaged)

Is synchronizer.js modified from the original source (other than by adding the attribution)? Maybe mention the git commit in case we ever need to update it.

MIT license requires copyright notice and license text. In case this is considered a "substantial portion" I'd suggest pasting https://github.com/danvk/dygraphs/blob/master/LICENSE.txt into a comment in synchronizer.js.

As for the actual content -- tested & works, LGTM.

#3 Updated by Tom Morris almost 4 years ago

at 0e2cc747caebc3e07cbbf0ed6ee18e8141646080

Added author copyright, MIT license, & reference to commit hash. (It is unchanged from original).
Added to MANIFEST.in (and removed webchart.js reference). Tested that ./setup.py build actually works.

#4 Updated by Tom Clegg almost 4 years ago

LGTM

#5 Updated by Anonymous almost 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF