Project

General

Profile

Actions

Bug #12884

closed

[Composer] Failure to connect to git not well reported

Added by Peter Amstutz about 6 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Story points:
-
Release relationship:
Auto

Subtasks 1 (0 open1 closed)

Task #12897: Review 12884-git-error-messageResolvedPeter Amstutz02/07/2018Actions
Actions #1

Updated by Peter Amstutz about 6 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Peter Amstutz about 6 years ago

  • Status changed from In Progress to New
Actions #3

Updated by Peter Amstutz about 6 years ago

  • Assigned To set to Peter Amstutz
Actions #5

Updated by Peter Amstutz about 6 years ago

  • Target version changed from 2018-01-17 Sprint to 2018-01-31 Sprint
Actions #6

Updated by Peter Amstutz about 6 years ago

  • Status changed from New to In Progress
  • Target version changed from 2018-01-31 Sprint to 2018-02-14 Sprint
Actions #7

Updated by Peter Amstutz about 6 years ago

Thought I fixed this but repository 404 error isn't being reported to the user, needs work.

Actions #8

Updated by Lucas Di Pentima about 6 years ago

The updates LGTM. One question about code style:

  • File src/app/core/panels/my-apps-panel/arvados-apps-panel.service.ts:
    • Line 90: Could load_dir() function be declared only once outside the .map() of .map()s, for example right below the getRootFolders() level? At first glance it seems that it uses very few outside vars that could be passed as parameters, and we avoid declaring lots of times the same function and improve a lot the readability.
Actions #9

Updated by Peter Amstutz about 6 years ago

Lucas Di Pentima wrote:

The updates LGTM. One question about code style:

  • File src/app/core/panels/my-apps-panel/arvados-apps-panel.service.ts:
    • Line 90: Could load_dir() function be declared only once outside the .map() of .map()s, for example right below the getRootFolders() level? At first glance it seems that it uses very few outside vars that could be passed as parameters, and we avoid declaring lots of times the same function and improve a lot the readability.

It calls itself recursively as well as capturing some variables from the outer scope. You're right there's a readability tradeoff here.

Actions #10

Updated by Lucas Di Pentima about 6 years ago

Just in case you're waiting for further feedback from me, this LGTM.

Actions #11

Updated by Peter Amstutz about 6 years ago

  • Status changed from In Progress to Resolved
Actions #12

Updated by Tom Morris over 5 years ago

  • Release set to 17
Actions

Also available in: Atom PDF