Arvados

Thought I fixed this but repository 404 error isn't being reported to the user, needs work.

The updates LGTM. One question about code style:

• File src/app/core/panels/my-apps-panel/arvados-apps-panel.service.ts:
  • Line 90: Could load_dir() function be declared only once outside the .map() of .map()s, for example right below the getRootFolders() level? At first glance it seems that it uses very few outside vars that could be passed as parameters, and we avoid declaring lots of times the same function and improve a lot the readability.

Lucas Di Pentima wrote:

The updates LGTM. One question about code style:

• File src/app/core/panels/my-apps-panel/arvados-apps-panel.service.ts:
  • Line 90: Could load_dir() function be declared only once outside the .map() of .map()s, for example right below the getRootFolders() level? At first glance it seems that it uses very few outside vars that could be passed as parameters, and we avoid declaring lots of times the same function and improve a lot the readability.

It calls itself recursively as well as capturing some variables from the outer scope. You're right there's a readability tradeoff here.

Just in case you're waiting for further feedback from me, this LGTM.