Arvados

The first two tests are trivial to fix, the 3rd test reveals the known problem that manifests can't represent empty directories. Current discussion is that crunch-run could scan for empty directories in the output and add a placeholder file so the directory is retained.

12934-cwl-conformance @ dc494faf90f5b3a83e73b8232c4150695dc25d46

However, one of the conformance tests themselves has a mistake:

https://github.com/common-workflow-language/common-workflow-language/pull/589

This converts the failing test into a "not supported" test because writable file/directory staging isn't supported (but we still ought to do it to get to 100% conformance, #12764)

This looks like a debug printf to remove:

                       for _, bind := range binds {
                               mnt := runner.Container.Mounts[bind]
                               // Check if there is a bind for this
                               // directory, in which case assume we don't need .keep
                               runner.CrunchLog.Printf("%v %v", path, bind)
                               if (containerPath == bind || strings.HasPrefix(containerPath, bind+"/")) && mnt.PortableDataHash != "d41d8cd98f00b204e9800998ecf8427e+0" {
                                       return
                               }
                       }

The rest LGTM

Tom Clegg wrote:

This looks like a debug printf to remove:

[...]

The rest LGTM

Thanks. Unfortunately although the CWL conformance tests pass, the unit tests are broken so I still have some work to do.