Bug #13037

[Composer] Link from workbench to composer should include API token

Added by Peter Amstutz over 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
02/14/2018
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Subtasks

Task #13075: Review 13037-composer-linkResolvedPeter Amstutz

Associated revisions

Revision 07aa5aa2
Added by Peter Amstutz over 2 years ago

Merge branch '13037-composer-link' closes #13037

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

History

#1 Updated by Peter Amstutz over 2 years ago

  • Assigned To set to Peter Amstutz

#2 Updated by Peter Amstutz over 2 years ago

  • Status changed from New to In Progress

#3 Updated by Peter Amstutz over 2 years ago

  • Target version changed from 2018-02-14 Sprint to 2018-02-28 Sprint

#4 Updated by Tom Clegg over 2 years ago

Make sure the token doesn't end up being copy-pasteable (see #11454 note-34, note-36)

#5 Updated by Lucas Di Pentima over 2 years ago

Branch 13037-composer-link at 338fff463f52e222c41ada21dc2b7d27e878e2b5 works correctly but has the security implications that Tom mentions on the comment above.

#6 Updated by Peter Amstutz over 2 years ago

13037-composer-link @ 6c99962c33249081e0a61aa9e843e09171784b26

Uses form with hidden input to obscure the api token.

Added styling for button to match other menu items in the dropdown menu.

#7 Updated by Tom Clegg over 2 years ago

LGTM

#8 Updated by Anonymous over 2 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

#9 Updated by Tom Morris about 2 years ago

  • Release set to 17

Also available in: Atom PDF