Project

General

Profile

Actions
Copy link

Bug #13037

closed

[Composer] Link from workbench to composer should include API token

Added by Peter Amstutz about 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Peter Amstutz
Category:
-
Target version:
2018-02-28 Sprint
Story points:
-
Release:
Arvados 1.1.4
Release relationship:
Auto

Subtasks 1 (0 open — 1 closed)

Task #13075: Review 13037-composer-linkResolvedPeter Amstutz02/14/2018Actions
Actions
Copy link
 #1

Updated by Peter Amstutz about 6 years ago

  • Assigned To set to Peter Amstutz
Actions
Copy link
 #2

Updated by Peter Amstutz about 6 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #3

Updated by Peter Amstutz about 6 years ago

  • Target version changed from 2018-02-14 Sprint to 2018-02-28 Sprint
Actions
Copy link
 #4

Updated by Tom Clegg about 6 years ago

Make sure the token doesn't end up being copy-pasteable (see #11454 note-34, note-36)

Actions
Copy link
 #5

Updated by Lucas Di Pentima about 6 years ago

Branch 13037-composer-link at 338fff463f52e222c41ada21dc2b7d27e878e2b5 works correctly but has the security implications that Tom mentions on the comment above.

Actions
Copy link
 #6

Updated by Peter Amstutz about 6 years ago

13037-composer-link @ 6c99962c33249081e0a61aa9e843e09171784b26

Uses form with hidden input to obscure the api token.

Added styling for button to match other menu items in the dropdown menu.

Actions
Copy link
 #7

Updated by Tom Clegg about 6 years ago

LGTM

Actions
Copy link
 #8

Updated by Anonymous about 6 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #9

Updated by Tom Morris almost 6 years ago

  • Release set to 17
Actions
Copy link

Also available in: Atom PDF