Bug #13106

[SDK] API errors in Python keepclient don't reset cache slot

Added by Peter Amstutz over 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
02/20/2018
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

In keepclient.get, a cache slot is reserved when starting a get operation so that multiple gets on the same block don't result in redundant downloads. Unfortunately, the cache slot is not reset if there is an API error (keepstore errors are handled), with the result that the next attempt to read the same block will hang forever.


Subtasks

Task #13107: Review 13106-keepclient-slotResolvedPeter Amstutz

Associated revisions

Revision 1632cb9f
Added by Peter Amstutz over 2 years ago

Merge branch '13106-keepclient-slot' closes #13106

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

History

#1 Updated by Peter Amstutz over 2 years ago

  • Status changed from New to In Progress

#3 Updated by Peter Amstutz over 2 years ago

  • Description updated (diff)

#4 Updated by Peter Amstutz over 2 years ago

  • Assigned To set to Peter Amstutz

#5 Updated by Lucas Di Pentima over 2 years ago

LGTM.

Just one question: Do you think it would be convenient to add a comment on the test pointing to the bug so that’s more clear as to why there are 2 asserts on the same operation?

#6 Updated by Peter Amstutz over 2 years ago

Lucas Di Pentima wrote:

LGTM.

Just one question: Do you think it would be convenient to add a comment on the test pointing to the bug so that’s more clear as to why there are 2 asserts on the same operation?

Yes, that's a good idea.

#7 Updated by Anonymous over 2 years ago

  • Status changed from In Progress to Resolved

#9 Updated by Tom Morris about 2 years ago

  • Release set to 17

Also available in: Atom PDF