Bug #13106
closed
[SDK] API errors in Python keepclient don't reset cache slot
Description
In keepclient.get, a cache slot is reserved when starting a get operation so that multiple gets on the same block don't result in redundant downloads. Unfortunately, the cache slot is not reset if there is an API error (keepstore errors are handled), with the result that the next attempt to read the same block will hang forever.
Updated by Peter Amstutz about 7 years ago
- Status changed from New to In Progress
Updated by Lucas Di Pentima about 7 years ago
LGTM.
Just one question: Do you think it would be convenient to add a comment on the test pointing to the bug so that’s more clear as to why there are 2 asserts on the same operation?
Updated by Peter Amstutz about 7 years ago
Lucas Di Pentima wrote:
LGTM.
Just one question: Do you think it would be convenient to add a comment on the test pointing to the bug so that’s more clear as to why there are 2 asserts on the same operation?
Yes, that's a good idea.
Updated by Anonymous about 7 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|1632cb9ffffc882987c69d2e5f8b91f849fa9d8c.
Updated by Tom Morris