Arvados

13327-include-container-uuid @ 5ae2812a591fe7335599d5202f9bd4e4090ebd60

developer-run-tests: #4421

• All agreed upon points are implemented / addressed.
  • search, project page, process page, and workflow page should all be using the new API
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • n/a
• Code is tested and passing, both automated and manual, what manual testing was done is described
  • waiting to see if it passes existing integration tests
  • need to add a test for the API fix for using 'container' filter on container requests with group contents
• Documentation has been updated.
  • n/a
• Behaves appropriately at the intended scale (describe intended scale).
  • should improve loading time by collapsing two requests into one, as well as solving a longstanding issue where containers show the wrong status
• Considered backwards and forwards compatibility issues between client and server.
  • the search panel is the one place where you're likely to see API mismatch between client and server, so the search middleware checks the API revision and determines which API to use
  • the other places do not, on the assumption that workbench 2 is upgraded together with its "home" API server.
• Follows our coding standards and GUI style guidelines.
  • yes

13327-include-container-uuid @ dd2ded8399c52a331ecdd300da2c270061c44c9a

developer-run-tests: #4448

• added a test case in API server groups_controller_test for fix I mentioned in the previous comment.
• updated the API intercepts to reflect they are using group contents instead of the container_request/container
• passes tests

• /processes-actions.ts L55: there is nothing in the catch block, meaning all exceptions will be ignored
• /search-results-middleware-service.ts L78, L100, L141, L158: I always twinge when I see a hardcoded value like this, even though we know it will never change. I recommend replacing it with a string constant at the top of the file (or maybe export it as a constant from /common/app-info.ts along with any other important version numbers, e.g. search-bar-actions.ts L381)
• /processes-middleware-service.ts L95-96: remove commented out code
• several unused imports/variables warnings in the terminal when running workbench, a few unrelated to this ticket

Lisa Knox wrote in #note-35:

Very thorough, just a few cleanup notes:

• /processes-actions.ts L55: there is nothing in the catch block, meaning all exceptions will be ignored

I added a snackbar error.

• /search-results-middleware-service.ts L78, L100, L141, L158: I always twinge when I see a hardcoded value like this, even though we know it will never change. I recommend replacing it with a string constant at the top of the file (or maybe export it as a constant from /common/app-info.ts along with any other important version numbers, e.g. search-bar-actions.ts L381)

Good call, they are symbolic constants in app-info.ts now.

• /processes-middleware-service.ts L95-96: remove commented out code

Done.

• several unused imports/variables warnings in the terminal when running workbench, a few unrelated to this ticket

I fixed all the warnings I saw.

13327-include-container-uuid @ cf84bf3fe656d25e9a081f4e3392375ec8b63f5a

developer-run-tests: #4456

LGTM!

There were some conflicts, so I rebased on main:

13327-include-container-uuid @ c18a6647f4431516e687e3a226d5be23854ddc89

developer-run-tests: #4462

13327-include-container-uuid @ 31eb5c0d41ef8ab362e93af23df3991aa433dea4

developer-run-tests: #4464