Project

General

Profile

Actions

Feature #13327

closed

More responsive page loads with API ?include=container_uuid

Added by Tom Morris over 6 years ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Story points:
-
Release:
Release relationship:
Auto

Description

These all need to be modified to use the group contents API, as that's the only one that supports ?include=container_uuid. This shouldn't be a problem since you can easily query container requests through the contents API.

  • Project listing
  • Other process listings (all processes, subprocesses, workflow definition history)
  • Loading the process panel details (currently the status badge often flickers because there's a delay in getting the correct status)

Subtasks 1 (0 open1 closed)

Task #16096: Review 13327-include-container-uuidResolvedPeter Amstutz09/25/2024Actions

Related issues

Related to Arvados Workbench 2 - Bug #15672: List of subprocesses limited in process viewResolvedLucas Di PentimaActions
Blocked by Arvados - Feature #12917: Support ?include=container_uuid for group contentsResolvedTom CleggActions
Actions #1

Updated by Tom Morris over 6 years ago

  • Related to Feature #12917: Support ?include=container_uuid for group contents added
Actions #2

Updated by Tom Morris over 6 years ago

  • Subject changed from Use new container_request?include=container to [Workbench] Use new API container_request?include=container
Actions #3

Updated by Peter Amstutz about 5 years ago

  • Related to Bug #15672: List of subprocesses limited in process view added
Actions #4

Updated by Peter Amstutz almost 5 years ago

  • Target version set to 2020-02-12 Sprint
Actions #5

Updated by Peter Amstutz almost 5 years ago

  • Category set to Workbench2
  • Subject changed from [Workbench] Use new API container_request?include=container to Use new API container_request?include=container
Actions #6

Updated by Lucas Di Pentima almost 5 years ago

  • Assigned To set to Lucas Di Pentima
Actions #7

Updated by Lucas Di Pentima almost 5 years ago

  • Related to deleted (Feature #12917: Support ?include=container_uuid for group contents)
Actions #8

Updated by Lucas Di Pentima almost 5 years ago

  • Blocked by Feature #12917: Support ?include=container_uuid for group contents added
Actions #9

Updated by Lucas Di Pentima over 4 years ago

  • Target version changed from 2020-02-12 Sprint to 2020-02-26 Sprint
Actions #10

Updated by Lucas Di Pentima over 4 years ago

  • Target version deleted (2020-02-26 Sprint)
  • Assigned To deleted (Lucas Di Pentima)
Actions #11

Updated by Peter Amstutz over 1 year ago

  • Release set to 60
Actions #12

Updated by Peter Amstutz over 1 year ago

  • Subject changed from Use new API container_request?include=container to More responsive page loads with API ?include=container_uuid
Actions #13

Updated by Peter Amstutz over 1 year ago

  • Release deleted (60)
  • Target version set to Future
Actions #14

Updated by Peter Amstutz 5 months ago

  • Target version changed from Future to Development 2024-07-24 sprint
Actions #15

Updated by Peter Amstutz 5 months ago

  • Target version changed from Development 2024-07-24 sprint to 439
Actions #16

Updated by Peter Amstutz 5 months ago

  • Target version changed from 439 to Development 2024-06-19 sprint
Actions #17

Updated by Peter Amstutz 5 months ago

  • Tracker changed from Idea to Feature
Actions #18

Updated by Peter Amstutz 5 months ago

  • Assigned To set to Stephen Smith
Actions #19

Updated by Peter Amstutz 5 months ago

  • Description updated (diff)
Actions #20

Updated by Peter Amstutz 5 months ago

  • Description updated (diff)
Actions #21

Updated by Peter Amstutz 5 months ago

  • Description updated (diff)
Actions #22

Updated by Peter Amstutz 5 months ago

  • Description updated (diff)
Actions #23

Updated by Peter Amstutz 5 months ago

  • Target version changed from Development 2024-06-19 sprint to Development 2024-07-03 sprint
Actions #24

Updated by Peter Amstutz 5 months ago

  • Release set to 70
Actions #25

Updated by Peter Amstutz 5 months ago

  • Assigned To deleted (Stephen Smith)
Actions #26

Updated by Peter Amstutz 5 months ago

  • Target version changed from Development 2024-07-03 sprint to Development 2024-07-24 sprint
Actions #27

Updated by Peter Amstutz 4 months ago

  • Target version changed from Development 2024-07-24 sprint to Development 2024-08-07 sprint
Actions #28

Updated by Peter Amstutz 4 months ago

  • Target version changed from Development 2024-08-07 sprint to Development 2024-08-28 sprint
Actions #29

Updated by Peter Amstutz 3 months ago

  • Assigned To set to Peter Amstutz
Actions #30

Updated by Peter Amstutz 2 months ago

  • Status changed from New to In Progress
Actions #31

Updated by Peter Amstutz 2 months ago

13327-include-container-uuid @ 5ae2812a591fe7335599d5202f9bd4e4090ebd60

developer-run-tests: #4421

  • All agreed upon points are implemented / addressed.
    • search, project page, process page, and workflow page should all be using the new API
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • n/a
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    • waiting to see if it passes existing integration tests
    • need to add a test for the API fix for using 'container' filter on container requests with group contents
  • Documentation has been updated.
    • n/a
  • Behaves appropriately at the intended scale (describe intended scale).
    • should improve loading time by collapsing two requests into one, as well as solving a longstanding issue where containers show the wrong status
  • Considered backwards and forwards compatibility issues between client and server.
    • the search panel is the one place where you're likely to see API mismatch between client and server, so the search middleware checks the API revision and determines which API to use
    • the other places do not, on the assumption that workbench 2 is upgraded together with its "home" API server.
  • Follows our coding standards and GUI style guidelines.
    • yes
Actions #32

Updated by Peter Amstutz 2 months ago

  • Target version changed from Development 2024-08-28 sprint to Development 2024-09-11 sprint
Actions #33

Updated by Peter Amstutz about 2 months ago

  • Target version changed from Development 2024-09-11 sprint to Development 2024-09-25 sprint
Actions #34

Updated by Peter Amstutz about 2 months ago

13327-include-container-uuid @ dd2ded8399c52a331ecdd300da2c270061c44c9a

developer-run-tests: #4448

  • added a test case in API server groups_controller_test for fix I mentioned in the previous comment.
  • updated the API intercepts to reflect they are using group contents instead of the container_request/container
  • passes tests
Actions #35

Updated by Lisa Knox about 2 months ago

Very thorough, just a few cleanup notes:
  • /processes-actions.ts L55: there is nothing in the catch block, meaning all exceptions will be ignored
  • /search-results-middleware-service.ts L78, L100, L141, L158: I always twinge when I see a hardcoded value like this, even though we know it will never change. I recommend replacing it with a string constant at the top of the file (or maybe export it as a constant from /common/app-info.ts along with any other important version numbers, e.g. search-bar-actions.ts L381)
  • /processes-middleware-service.ts L95-96: remove commented out code
  • several unused imports/variables warnings in the terminal when running workbench, a few unrelated to this ticket
Actions #36

Updated by Peter Amstutz about 2 months ago

Lisa Knox wrote in #note-35:

Very thorough, just a few cleanup notes:
  • /processes-actions.ts L55: there is nothing in the catch block, meaning all exceptions will be ignored

I added a snackbar error.

  • /search-results-middleware-service.ts L78, L100, L141, L158: I always twinge when I see a hardcoded value like this, even though we know it will never change. I recommend replacing it with a string constant at the top of the file (or maybe export it as a constant from /common/app-info.ts along with any other important version numbers, e.g. search-bar-actions.ts L381)

Good call, they are symbolic constants in app-info.ts now.

  • /processes-middleware-service.ts L95-96: remove commented out code

Done.

  • several unused imports/variables warnings in the terminal when running workbench, a few unrelated to this ticket

I fixed all the warnings I saw.

13327-include-container-uuid @ cf84bf3fe656d25e9a081f4e3392375ec8b63f5a

developer-run-tests: #4456

Actions #37

Updated by Lisa Knox about 2 months ago

LGTM!

Actions #38

Updated by Peter Amstutz about 2 months ago

There were some conflicts, so I rebased on main:

13327-include-container-uuid @ c18a6647f4431516e687e3a226d5be23854ddc89

developer-run-tests: #4462

Actions #40

Updated by Peter Amstutz about 1 month ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF