Feature #13431

[keepproxy] [GoSDK] Propagate desired storage classes in PUT request headers

Added by Tom Clegg over 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
06/05/2018
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
1.0
Release:
Release relationship:
Auto

Description

  • Add storage classes support to Keepclient
  • If a client request includes the ‘X-Keep-Storage-Class’ header, use the newly added keepclient feature.

Subtasks

Task #13526: Review 13431-keepproxy-storage-classes-headersClosedLucas Di Pentima


Related issues

Blocks Arvados - Feature #11184: [Keep] Support multiple storage classesIn Progress

Associated revisions

Revision 0eedf70a
Added by Lucas Di Pentima about 1 year ago

Merge branch '13431-keepproxy-storage-classes-headers'
Closes #13431

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

History

#1 Updated by Tom Clegg over 1 year ago

  • Blocks Feature #11184: [Keep] Support multiple storage classes added

#2 Updated by Tom Morris over 1 year ago

  • Target version set to To Be Groomed

#3 Updated by Lucas Di Pentima over 1 year ago

  • Description updated (diff)

#4 Updated by Tom Clegg over 1 year ago

  • Story points set to 1.0

#5 Updated by Lucas Di Pentima over 1 year ago

  • Subject changed from [keepproxy] [Go] Propagate desired storage classes in PUT request headers to [keepproxy] [GoSDK] Propagate desired storage classes in PUT request headers
  • Description updated (diff)

#6 Updated by Tom Morris over 1 year ago

  • Target version changed from To Be Groomed to Arvados Future Sprints

#7 Updated by Tom Morris over 1 year ago

  • Target version changed from Arvados Future Sprints to 2018-06-06 Sprint

#8 Updated by Lucas Di Pentima over 1 year ago

  • Assigned To set to Lucas Di Pentima

#9 Updated by Lucas Di Pentima over 1 year ago

  • Status changed from New to In Progress

#10 Updated by Lucas Di Pentima about 1 year ago

Updates at dd97299b6 - branch 13431-keepproxy-storage-classes-headers
Test run: https://ci.curoverse.com/job/developer-run-tests/735/

  • Added keepclient & keepproxy support for storage classes

I'm not sure how to write tests for keepproxy. Should I write some kind of keepstore fake server to be able to read requests coming from keepproxy?

#11 Updated by Tom Clegg about 1 year ago

LGTM

For keepproxy testing, you could use httptest.NewServer() to make a keepstore stub that just stashes the request headers and responds 500, make keepproxy connect to the stub using the same approach as TestAskGetKeepProxyConnectionError(), then check that the expected header was received.

#12 Updated by Lucas Di Pentima about 1 year ago

Updates at 7b7950766
Test run: https://ci.curoverse.com/job/developer-run-tests/737/

  • Added test that confirms X-Keep-Storage-Classes header propagation
  • Fixed TestAskGetKeepProxyConnectionError test, which wasn't testing keepproxy, but keepclient.

#13 Updated by Lucas Di Pentima about 1 year ago

(Don't pay attention to those 3 commented lines :) - e80efb5ca )

#14 Updated by Tom Clegg about 1 year ago

LGTM, thanks

#15 Updated by Lucas Di Pentima about 1 year ago

  • Status changed from In Progress to Resolved

#16 Updated by Tom Morris about 1 year ago

  • Release set to 13

Also available in: Atom PDF