Project

General

Profile

Actions

Feature #13431

closed

[keepproxy] [GoSDK] Propagate desired storage classes in PUT request headers

Added by Tom Clegg almost 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
06/05/2018
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
1.0
Release:
Release relationship:
Auto

Description

  • Add storage classes support to Keepclient
  • If a client request includes the ‘X-Keep-Storage-Class’ header, use the newly added keepclient feature.

Subtasks 1 (0 open1 closed)

Task #13526: Review 13431-keepproxy-storage-classes-headersClosedLucas Di Pentima06/05/2018

Actions

Related issues

Blocks Arvados - Feature #11184: [Keep] Support multiple storage classesResolvedTom Morris

Actions
Actions #1

Updated by Tom Clegg almost 5 years ago

  • Blocks Feature #11184: [Keep] Support multiple storage classes added
Actions #2

Updated by Tom Morris almost 5 years ago

  • Target version set to To Be Groomed
Actions #3

Updated by Lucas Di Pentima over 4 years ago

  • Description updated (diff)
Actions #4

Updated by Tom Clegg over 4 years ago

  • Story points set to 1.0
Actions #5

Updated by Lucas Di Pentima over 4 years ago

  • Subject changed from [keepproxy] [Go] Propagate desired storage classes in PUT request headers to [keepproxy] [GoSDK] Propagate desired storage classes in PUT request headers
  • Description updated (diff)
Actions #6

Updated by Tom Morris over 4 years ago

  • Target version changed from To Be Groomed to Arvados Future Sprints
Actions #7

Updated by Tom Morris over 4 years ago

  • Target version changed from Arvados Future Sprints to 2018-06-06 Sprint
Actions #8

Updated by Lucas Di Pentima over 4 years ago

  • Assigned To set to Lucas Di Pentima
Actions #9

Updated by Lucas Di Pentima over 4 years ago

  • Status changed from New to In Progress
Actions #10

Updated by Lucas Di Pentima over 4 years ago

Updates at dd97299b6 - branch 13431-keepproxy-storage-classes-headers
Test run: https://ci.curoverse.com/job/developer-run-tests/735/

  • Added keepclient & keepproxy support for storage classes

I'm not sure how to write tests for keepproxy. Should I write some kind of keepstore fake server to be able to read requests coming from keepproxy?

Actions #11

Updated by Tom Clegg over 4 years ago

LGTM

For keepproxy testing, you could use httptest.NewServer() to make a keepstore stub that just stashes the request headers and responds 500, make keepproxy connect to the stub using the same approach as TestAskGetKeepProxyConnectionError(), then check that the expected header was received.

Actions #12

Updated by Lucas Di Pentima over 4 years ago

Updates at 7b7950766
Test run: https://ci.curoverse.com/job/developer-run-tests/737/

  • Added test that confirms X-Keep-Storage-Classes header propagation
  • Fixed TestAskGetKeepProxyConnectionError test, which wasn't testing keepproxy, but keepclient.
Actions #13

Updated by Lucas Di Pentima over 4 years ago

(Don't pay attention to those 3 commented lines :) - e80efb5ca )

Actions #14

Updated by Tom Clegg over 4 years ago

LGTM, thanks

Actions #15

Updated by Lucas Di Pentima over 4 years ago

  • Status changed from In Progress to Resolved
Actions #16

Updated by Tom Morris over 4 years ago

  • Release set to 13
Actions

Also available in: Atom PDF