Feature #13431
closed
[keepproxy] [GoSDK] Propagate desired storage classes in PUT request headers
Added by Tom Clegg over 6 years ago.
Updated over 6 years ago.
Release relationship:
Auto
Description
- Add storage classes support to Keepclient
- If a client request includes the ‘X-Keep-Storage-Class’ header, use the newly added keepclient feature.
- Target version set to To Be Groomed
- Description updated (diff)
- Subject changed from [keepproxy] [Go] Propagate desired storage classes in PUT request headers to [keepproxy] [GoSDK] Propagate desired storage classes in PUT request headers
- Description updated (diff)
- Target version changed from To Be Groomed to Arvados Future Sprints
- Target version changed from Arvados Future Sprints to 2018-06-06 Sprint
- Assigned To set to Lucas Di Pentima
- Status changed from New to In Progress
Updates at dd97299b6 - branch 13431-keepproxy-storage-classes-headers
Test run: https://ci.curoverse.com/job/developer-run-tests/735/
- Added keepclient & keepproxy support for storage classes
I'm not sure how to write tests for keepproxy. Should I write some kind of keepstore fake server to be able to read requests coming from keepproxy?
LGTM
For keepproxy testing, you could use httptest.NewServer() to make a keepstore stub that just stashes the request headers and responds 500, make keepproxy connect to the stub using the same approach as TestAskGetKeepProxyConnectionError(), then check that the expected header was received.
(Don't pay attention to those 3 commented lines :) - e80efb5ca )
- Status changed from In Progress to Resolved
Also available in: Atom
PDF
Updated by 
Updated by Tom Morris 
Updated by