Project

General

Profile

Actions

Story #13569

closed

Add units tera / giga / mega / kilo for configurations

Added by Nico César over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
06/29/2018
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
1.0
Release:
Release relationship:
Auto

Description

It will be great to have suffixes in configurations to express [TGMK][i]B note the "i" to take in account both options for MiB Mebibytes and MB Megabytes to make configuration simpler in systems that express Disk size (usually in Megabytes ) and Memory (usually in Mebibytes:

/etc/arvados/config.yml
Clusters:
  zzzzz:
    InstanceTypes:
    - Name: Standard_D1_v2
      VCPUs: 1
      RAM: 3.584GiB
      Scratch: 50GB
      Price: 0.073

this should be consistent across the different configurations as in :

/etc/arvados-node-manager/config.ini
[Size Standard_E64_v3]
cores = 64
price = 4.412
scratch = 864000

Subtasks 1 (0 open1 closed)

Task #13656: Review 13569-size-prefixesResolvedLucas Di Pentima06/29/2018

Actions

Related issues

Related to Arvados - Feature #13611: Nodemanager reads instance sizes from the system config file to avoid duplicationClosed

Actions
Actions #1

Updated by Nico César over 4 years ago

  • Project changed from 35 to Arvados
  • Target version set to To Be Groomed
Actions #2

Updated by Lucas Di Pentima over 4 years ago

  • Related to Feature #13611: Nodemanager reads instance sizes from the system config file to avoid duplication added
Actions #3

Updated by Tom Morris over 4 years ago

  • Story points set to 1.0
Actions #4

Updated by Tom Morris over 4 years ago

  • Target version changed from To Be Groomed to 2018-07-03 Sprint
Actions #5

Updated by Tom Clegg over 4 years ago

  • Assigned To set to Tom Clegg
Actions #6

Updated by Tom Clegg over 4 years ago

  • Status changed from New to In Progress
Actions #7

Updated by Tom Clegg over 4 years ago

13569-size-prefixes @ 11ab2e23511c7e8962e0110c3aad44b74fea2dbd
  • incorporates outstanding branch from #13674 (rather than create+resolve merge conflicts)
  • applies only to Go programs (because so far only Go programs read the cluster config file)
  • nodemanager's own "ini" config file still reads "30" to mean "30 GB", and can't handle "30000 MB" -- it's pointless to add this feature when we're already planning to ditch the whole thing in #13611, right?

https://ci.curoverse.com/job/developer-run-tests/778/

Actions #8

Updated by Lucas Di Pentima over 4 years ago

Updates at 11ab2e23511c7e8962e0110c3aad44b74fea2dbd LGTM, except for one thing that may be an issue to be solved: This doesn't work with decimal values, for example: 3.584GiB, as in the example conf on the description.

Actions #9

Updated by Tom Clegg over 4 years ago

13569-size-prefixes @ d128fe6bc8da01fe8e7829db988819dd1c159298

Now accepts any valid JSON number as the numeric part: "1.234K", "1234E-3 EiB", etc.

Actions #10

Updated by Lucas Di Pentima over 4 years ago

LGTM, please merge.

Actions #11

Updated by Tom Clegg over 4 years ago

  • Status changed from In Progress to Resolved
Actions #12

Updated by Tom Morris over 4 years ago

  • Tracker changed from Bug to Story
  • Subject changed from add units tera / giga / mega / kilo for configurations. to Add units tera / giga / mega / kilo for configurations
  • Release set to 13
Actions

Also available in: Atom PDF