Project

General

Profile

Actions

Bug #13934

closed

add code comment to avoid reversion of 13788

Added by Joshua Randall over 6 years ago. Updated about 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Documentation
Target version:
Story points:
-
Release:
Release relationship:
Auto

Description

While working on 13933, I inadvertently reverted the concurrent map access bug that was fixed in 13788 (by moving the list var declaration out of the loop so that I could use it for the initial `limit: 0` `count: exact` call).

I would suggest adding a comment to the var declaration to make a particular point of it being absolutely necessary to declare it afresh in each loop iteration, as I suspect it would otherwise be likely that the same mistake will be made again.


Subtasks 1 (0 open1 closed)

Task #13946: Review 13934-guard-commentClosedTom Morris08/01/2018Actions
Actions #1

Updated by Tom Clegg over 6 years ago

  • Assigned To set to Tom Clegg
  • Target version set to 2018-08-15 Sprint
Actions #2

Updated by Tom Clegg over 6 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Tom Clegg over 6 years ago

Actions #4

Updated by Tom Morris over 6 years ago

LGTM

(I was going to suggest that replacing the colon with a period/full stop was more grammatically correct, but then thought that might be considered bikeshedding (or is it bike-shedding?)) ;-)

Actions #5

Updated by Tom Clegg over 6 years ago

  • Status changed from In Progress to Resolved
Actions #6

Updated by Tom Morris about 6 years ago

  • Release set to 13
Actions

Also available in: Atom PDF