Bug #13934

add code comment to avoid reversion of 13788

Added by Joshua Randall over 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Documentation
Target version:
Start date:
08/01/2018
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release:
Release relationship:
Auto

Description

While working on 13933, I inadvertently reverted the concurrent map access bug that was fixed in 13788 (by moving the list var declaration out of the loop so that I could use it for the initial `limit: 0` `count: exact` call).

I would suggest adding a comment to the var declaration to make a particular point of it being absolutely necessary to declare it afresh in each loop iteration, as I suspect it would otherwise be likely that the same mistake will be made again.


Subtasks

Task #13946: Review 13934-guard-commentClosedTom Morris

Associated revisions

Revision f4faf6f0
Added by Tom Clegg over 2 years ago

Merge branch '13934-guard-comment'

closes #13934

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

History

#1 Updated by Tom Clegg over 2 years ago

  • Assigned To set to Tom Clegg
  • Target version set to 2018-08-15 Sprint

#2 Updated by Tom Clegg over 2 years ago

  • Status changed from New to In Progress

#3 Updated by Tom Clegg over 2 years ago

#4 Updated by Tom Morris over 2 years ago

LGTM

(I was going to suggest that replacing the colon with a period/full stop was more grammatically correct, but then thought that might be considered bikeshedding (or is it bike-shedding?)) ;-)

#5 Updated by Tom Clegg over 2 years ago

  • Status changed from In Progress to Resolved

#6 Updated by Tom Morris about 2 years ago

  • Release set to 13

Also available in: Atom PDF