https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422018-08-08T15:12:53ZArvadosArvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=654872018-08-08T15:12:53ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Subject</strong> changed from <i> [API] Fetch remote-hosted container by UUID</i> to <i> [API] Fetch remote-hosted collection by UUID</i></li><li><strong>Description</strong> updated (<a title="View differences" href="/journals/65487/diff?detail_id=62411">diff</a>)</li></ul> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=654882018-08-08T15:13:09ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-3 priority-4 priority-default closed parent" href="/issues/13493">Feature #13493</a>: Federated record retrieval</i> added</li></ul> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=654902018-08-08T15:13:15ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-3 priority-4 priority-default closed parent" href="/issues/13994">Feature #13994</a>: [Keepstore] Fetch blocks from federated clusters</i> added</li></ul> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=654922018-08-08T15:13:38ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/65492/diff?detail_id=62416">diff</a>)</li></ul> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=654932018-08-08T15:14:21ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/65493/diff?detail_id=62417">diff</a>)</li></ul> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=654942018-08-08T15:18:00ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/65494/diff?detail_id=62418">diff</a>)</li></ul> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=655152018-08-08T16:47:49ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Target version</strong> changed from <i>To Be Groomed</i> to <i>Arvados Future Sprints</i></li><li><strong>Story points</strong> set to <i>2.0</i></li></ul> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=655762018-08-10T03:26:33ZTom Cleggtom@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/65576/diff?detail_id=62500">diff</a>)</li></ul> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=657602018-08-15T16:35:48ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Target version</strong> changed from <i>Arvados Future Sprints</i> to <i>2018-09-05 Sprint</i></li></ul> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=657612018-08-15T16:36:01ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Assigned To</strong> set to <i>Fuad Muhic</i></li></ul> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=659422018-08-20T13:05:46ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Assigned To</strong> deleted (<del><i>Fuad Muhic</i></del>)</li></ul> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=660332018-08-21T19:51:36ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-3 priority-4 priority-default closed parent" href="/issues/14087">Feature #14087</a>: [controller] Fetch remote-hosted collections by PDH</i> added</li></ul> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=664542018-09-05T14:49:46ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2018-09-05 Sprint</i> to <i>2018-09-19 Sprint</i></li></ul> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=664692018-09-05T15:41:08ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Subject</strong> changed from <i> [API] Fetch remote-hosted collection by UUID</i> to <i>[API] Fetch remote-hosted collection by UUID</i></li><li><strong>Assigned To</strong> set to <i>Peter Amstutz</i></li></ul> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=665642018-09-07T20:08:43ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>13993-federated-collection @ <a class="changeset" title="13993: Support for federated collection requests by uuid Do remote record retrevial using a salt..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/9c1f240500cca97fe986b529fcfc9c7f9fe1a283">9c1f240500cca97fe986b529fcfc9c7f9fe1a283</a></p>
<p><a class="external" href="https://ci.curoverse.com/view/Developer/job/developer-run-tests/877/">https://ci.curoverse.com/view/Developer/job/developer-run-tests/877/</a></p> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=666002018-09-10T16:17:30ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Some comments:</p>
<ul>
<li>On file <code>lib/controller/federation.go</code>
<ul>
<li>Line 96 - Small detail: I think just multiplying by 1.1 would more readable</li>
<li>Line 76: Docs about locator format talks about lowercase hex digits (<a class="external" href="https://doc.arvados.org/api/storage.html">https://doc.arvados.org/api/storage.html</a> & <a class="external" href="https://dev.arvados.org/projects/arvados/wiki/Keep_locator_format">https://dev.arvados.org/projects/arvados/wiki/Keep_locator_format</a>), should we stick to that definition?</li>
</ul>
</li>
<li>I think it would be convenient to update the locator format documentation to describe a <code>+R</code> hint</li>
<li>We have a previous signed locator Regex on <code>sdk/go/keepclient/perms.go:68</code> that looks more correct (because I believe the current one doesn’t allow <code>+A</code> hints that aren’t signature hints), should we export it so it can be reused here?</li>
<li>Tests are failing</li>
</ul> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=666052018-09-10T20:19:02ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Lucas Di Pentima wrote:</p>
<blockquote>
<p>Some comments:</p>
<ul>
<li>On file <code>lib/controller/federation.go</code>
<ul>
<li>Line 96 - Small detail: I think just multiplying by 1.1 would more readable</li>
</ul></li>
</ul>
</blockquote>
<p>I was trying to avoid converting to double precision and back but I agree that's a silly micro-optimization in this case at the expense of readability</p>
<blockquote>
<ul>
<li>Line 76: Docs about locator format talks about lowercase hex digits (<a class="external" href="https://doc.arvados.org/api/storage.html">https://doc.arvados.org/api/storage.html</a> & <a class="external" href="https://dev.arvados.org/projects/arvados/wiki/Keep_locator_format">https://dev.arvados.org/projects/arvados/wiki/Keep_locator_format</a>), should we stick to that definition?</li>
</ul>
</blockquote>
<p>See below</p>
<blockquote>
<ul>
<li>I think it would be convenient to update the locator format documentation to describe a <code>+R</code> hint</li>
</ul>
</blockquote>
<p>I have a documentation story to write up federation features (the task on <a class="issue tracker-2 status-3 priority-4 priority-default closed parent" title="Feature: Federated record retrieval (Resolved)" href="https://dev.arvados.org/issues/13493">#13493</a> assigned to me), maybe I can do it there?</p>
<blockquote>
<ul>
<li>We have a previous signed locator Regex on <code>sdk/go/keepclient/perms.go:68</code> that looks more correct (because I believe the current one doesn’t allow <code>+A</code> hints that aren’t signature hints), should we export it so it can be reused here?</li>
</ul>
</blockquote>
<p>I consolidated the regex so the one in keepclient can be used by federation.go</p>
<blockquote>
<ul>
<li>Tests are failing</li>
</ul>
</blockquote>
<p>Works for me... Kicked off a run here: <a class="external" href="https://ci.curoverse.com/view/Developer/job/developer-run-tests/881/">https://ci.curoverse.com/view/Developer/job/developer-run-tests/881/</a></p> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=666102018-09-10T22:16:36ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Now <a class="changeset" title="13993: Need to explicitly handle paths that don't end in / Otherwise Go will generate a 301 Move..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/fe235611ed2a624783067e65b02b319fa687f372">fe235611ed2a624783067e65b02b319fa687f372</a></p>
<p>Try this <a class="external" href="https://ci.curoverse.com/view/Developer/job/developer-run-tests/882/">https://ci.curoverse.com/view/Developer/job/developer-run-tests/882/</a></p> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=666232018-09-11T14:01:56ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Just one question: Would it be convenient to also add a test for a local collection request, so we test both sides?<br />Apart from that, it LGTM.</p> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=666252018-09-11T15:06:41ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Lucas Di Pentima wrote:</p>
<blockquote>
<p>Just one question: Would it be convenient to also add a test for a local collection request, so we test both sides?<br />Apart from that, it LGTM.</p>
</blockquote>
<p>Added TestGetLocalCollection @ <a class="changeset" title="13993: Add TestGetLocalCollection Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritas..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/9d2e1158e961801db714236c6942bd3596b867e7">9d2e1158e961801db714236c6942bd3596b867e7</a></p> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=666272018-09-11T15:32:01ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Thanks! This lgtm.</p> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=667442018-09-14T14:35:54ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li></ul> Arvados - Feature #13993: [API] Fetch remote-hosted collection by UUIDhttps://dev.arvados.org/issues/13993?journal_id=687012018-11-13T21:00:38ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Release</strong> set to <i>14</i></li></ul>