Feature #14141

[Backend] Trashed files

Added by Daniel Kos almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Story points:
1.0

Associated revisions

Revision ecfa844e (diff)
Added by Daniel Kos over 1 year ago

Fix filtering by is_trashed field

Feature #14141

Arvados-DCO-1.1-Signed-off-by: Daniel Kos <>

Revision 1102aee7 (diff)
Added by Daniel Kos over 1 year ago

Fix passing tests

Feature #14141

Arvados-DCO-1.1-Signed-off-by: Daniel Kos <>

Revision a899e5b1
Added by Daniel Kos over 1 year ago

refs #14141 Merge branch 'origin/14141-trash-view-fix'

Arvados-DCO-1.1-Signed-off-by: Daniel Kos <>

History

#1 Updated by Daniel Kos almost 2 years ago

Currently to get list of trashed files one has to add:

includeTrash: true

to /groups/{uuid}/contents call. The problem with that is all files that belongs to uuid will be returned even not trashed ones. That causes problems with trash panel where only trashed files should be displayed. Client has to manually filter out items that has isTrashed set to true. That works but doesn't integrate well with limit and offset parameters. Client can't rely on that when user switches page or changes items per row. So it would be good is filtering on server by isTrashed field was possible. Currently that is not working

#2 Updated by Tom Morris over 1 year ago

  • Status changed from New to In Progress
  • Assigned To set to Tom Clegg

I think TomC tested this and believes it works (although you need an explicit filter=[] parameter).

Assigning to him for additional comment...

#3 Updated by Chrystian Klingenberg over 1 year ago

  • Target version set to sprint 8

#4 Updated by Tom Clegg over 1 year ago

Filters like this should work:

filters=[["uuid", "is_a", ["arvados#collection", "arvados#group"]], ["is_trashed", "=", true]]

Here is a test case:
https://github.com/curoverse/arvados/blob/master/services/api/test/functional/arvados/v1/groups_controller_test.rb#L121-L129

#5 Updated by Daniel Kos over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

#6 Updated by Daniel Kos over 1 year ago

  • Story points set to 1.0

Also available in: Atom PDF