Project

General

Profile

Actions
Copy link

Feature #14141

closed

[Backend] Trashed files

Added by Daniel Kos over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assigned To:
Tom Clegg
Category:
-
Target version:
sprint 8
Story points:
1.0
Actions
Copy link
 #1

Updated by Daniel Kos over 5 years ago

Currently to get list of trashed files one has to add:

includeTrash: true

to /groups/{uuid}/contents call. The problem with that is all files that belongs to uuid will be returned even not trashed ones. That causes problems with trash panel where only trashed files should be displayed. Client has to manually filter out items that has isTrashed set to true. That works but doesn't integrate well with limit and offset parameters. Client can't rely on that when user switches page or changes items per row. So it would be good is filtering on server by isTrashed field was possible. Currently that is not working

Actions
Copy link
 #2

Updated by Tom Morris over 5 years ago

  • Status changed from New to In Progress
  • Assigned To set to Tom Clegg

I think TomC tested this and believes it works (although you need an explicit filter=[] parameter).

Assigning to him for additional comment...

Actions
Copy link
 #3

Updated by Chrystian Klingenberg over 5 years ago

  • Target version set to sprint 8
Actions
Copy link
 #4

Updated by Tom Clegg over 5 years ago

Filters like this should work:

filters=[["uuid", "is_a", ["arvados#collection", "arvados#group"]], ["is_trashed", "=", true]]

Here is a test case:
https://github.com/curoverse/arvados/blob/master/services/api/test/functional/arvados/v1/groups_controller_test.rb#L121-L129

Actions
Copy link
 #5

Updated by Daniel Kos over 5 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #6

Updated by Daniel Kos over 5 years ago

  • Story points set to 1.0
Actions
Copy link

Also available in: Atom PDF