Story #14242

[controller] Verify hash on manifest text when querying by PDH

Added by Peter Amstutz 11 months ago. Updated 10 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
09/19/2018
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5
Release:
Release relationship:
Auto

Description

As came up in the sprint review, when sending out a query for a collection by PDH, controller should verify that the manifest text that is returned matches the PDH.


Subtasks

Task #14243: Review 14242-verify-manifest-pdhResolvedLucas Di Pentima

Associated revisions

Revision a0789339
Added by Peter Amstutz 11 months ago

Merge branch '14242-verify-manifest-pdh' closes #14242

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

History

#1 Updated by Peter Amstutz 11 months ago

  • Status changed from New to In Progress

#2 Updated by Peter Amstutz 11 months ago

  • Description updated (diff)
  • Story points set to 0.5

#3 Updated by Peter Amstutz 11 months ago

  • Assigned To set to Peter Amstutz

#4 Updated by Lucas Di Pentima 11 months ago

Reviewing 720e76bb1d82d5a5448ce395df634310ceee473e

This lgtm, but I think adding test cases would be convenient.

#5 Updated by Peter Amstutz 11 months ago

Lucas Di Pentima wrote:

Reviewing 720e76bb1d82d5a5448ce395df634310ceee473e

This lgtm, but I think adding test cases would be convenient.

Test added, also added check that the portable_data_hash record field is consistent with manifest_text hash and requested PDH.

Now @ 494cc8312cff496bab3653d5b2ab1f00ac43a40c

https://ci.curoverse.com/view/Developer/job/developer-run-tests/900/

#6 Updated by Lucas Di Pentima 11 months ago

This lgtm, thanks.

#7 Updated by Peter Amstutz 11 months ago

  • Status changed from In Progress to Resolved

#8 Updated by Tom Morris 10 months ago

  • Release set to 14

Also available in: Atom PDF