Project

General

Profile

Actions
Copy link

Idea #14242

closed

[controller] Verify hash on manifest text when querying by PDH

Added by Peter Amstutz over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Peter Amstutz
Category:
-
Target version:
2018-10-03 Sprint
Start date:
09/19/2018
Due date:
Story points:
0.5
Release:
Arvados 1.3
Release relationship:
Auto

Description

As came up in the sprint review, when sending out a query for a collection by PDH, controller should verify that the manifest text that is returned matches the PDH.

Subtasks 1 (0 open — 1 closed)

Task #14243: Review 14242-verify-manifest-pdhResolvedLucas Di Pentima09/19/2018Actions
Actions
Copy link
 #1

Updated by Peter Amstutz over 5 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #2

Updated by Peter Amstutz over 5 years ago

  • Description updated (diff)
  • Story points set to 0.5
Actions
Copy link
 #3

Updated by Peter Amstutz over 5 years ago

  • Assigned To set to Peter Amstutz
Actions
Copy link
 #4

Updated by Lucas Di Pentima over 5 years ago

Reviewing 720e76bb1d82d5a5448ce395df634310ceee473e

This lgtm, but I think adding test cases would be convenient.

Actions
Copy link
 #5

Updated by Peter Amstutz over 5 years ago

Lucas Di Pentima wrote:

Reviewing 720e76bb1d82d5a5448ce395df634310ceee473e

This lgtm, but I think adding test cases would be convenient.

Test added, also added check that the portable_data_hash record field is consistent with manifest_text hash and requested PDH.

Now @ 494cc8312cff496bab3653d5b2ab1f00ac43a40c

https://ci.curoverse.com/view/Developer/job/developer-run-tests/900/

Actions
Copy link
 #6

Updated by Lucas Di Pentima over 5 years ago

This lgtm, thanks.

Actions
Copy link
 #7

Updated by Peter Amstutz over 5 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link
 #8

Updated by Tom Morris over 5 years ago

  • Release set to 14
Actions
Copy link

Also available in: Atom PDF