Bug #14519

[Workbench] Textile table markup

Added by Peter Amstutz 9 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
11/26/2018
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release:
Release relationship:
Auto

Description

Customer wrote:

I was wondering if there have been any recent changes to the markup syntax used for Project/Collection descriptions in the Arvados Workbench?

I have previously been arranging some metadata into a table and storing this in Collection descriptions (as well as in the 'properties' field of the Collection record). We recently upgraded our installation to 1.2.0 and now the tables are no longer displaying as they were.

I'm using this table syntax;

table(table table-striped table-condensed).
|_. First Header |_. Second Header |
|Content Cell |Content Cell |
|Content Cell |Content Cell |

I'm sure the Textile markup system was in use before, and aspects of that syntax still work, but tables do not.


Subtasks

Task #14531: Review 14519-wb-textile-issuesResolvedLucas Di Pentima

Associated revisions

Revision d8333e9e
Added by Lucas Di Pentima 9 months ago

Merge branch '14519-wb-textile-issues'
Closes #14519

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

History

#1 Updated by Peter Amstutz 9 months ago

  • Status changed from New to In Progress

#2 Updated by Peter Amstutz 9 months ago

  • Description updated (diff)
  • Status changed from In Progress to New

#3 Updated by Lucas Di Pentima 9 months ago

  • Assigned To set to Lucas Di Pentima
  • Target version set to 2018-11-28 Sprint

#4 Updated by Lucas Di Pentima 9 months ago

Here's another example of a collection with a table that used to work: https://workbench.qr1hi.arvadosapi.com/projects/qr1hi-j7d0g-i294hnh7yxhftp8

#6 Updated by Lucas Di Pentima 9 months ago

  • Status changed from New to In Progress

#7 Updated by Lucas Di Pentima 9 months ago

Updates at 8299fa11d1e813ea52e3ea482214d12044119bc3 - branch 14519-wb-textile-issues
Test run: https://ci.curoverse.com/job/developer-run-tests/983/
Fuse tests retry: https://ci.curoverse.com/job/developer-run-tests-services-fuse/997/

Added table related tags to sanitize()'s tag whitelist. For some reason rails doesn't include them by default. See: https://github.com/rails/rails-html-sanitizer/issues/50

#8 Updated by Tom Clegg 9 months ago

I think it would make sense to add the other table elements too — col, colgroup, caption, thead, tfoot — assuming there's no reason not to?

LGTM

#9 Updated by Lucas Di Pentima 9 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

#10 Updated by Tom Morris 9 months ago

  • Release set to 14

Also available in: Atom PDF