Story #14794

Link from Workbench 1 to Workbench 2

Added by Tom Morris 5 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
02/22/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Using the identity url for the Workbench 1 append "2" to the first piece and link to the workbench 2 home page.


Subtasks

Task #14798: Review 14794-link-wb1-to-wb2ResolvedLucas Di Pentima


Related issues

Related to Arvados - Story #14841: Link from Workbench 2 to Workbench 1Resolved02/14/2019

Associated revisions

Revision 48ee3654
Added by Lucas Di Pentima 4 months ago

Merge branch '14794-link-wb1-to-wb2'
Closes #14794

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

History

#1 Updated by Tom Morris 5 months ago

  • Status changed from New to In Progress

#2 Updated by Tom Morris 5 months ago

  • Status changed from In Progress to New

#3 Updated by Tom Morris 5 months ago

  • Description updated (diff)

#4 Updated by Lucas Di Pentima 5 months ago

  • Assigned To set to Lucas Di Pentima

#5 Updated by Lucas Di Pentima 4 months ago

  • Target version changed from 2019-02-13 Sprint to 2019-02-27 Sprint

#6 Updated by Tom Morris 4 months ago

  • Related to Story #14841: Link from Workbench 2 to Workbench 1 added

#7 Updated by Lucas Di Pentima 4 months ago

Updates at 408e81ed6 - branch 14794-link-wb1-to-wb2
Test run: https://ci.curoverse.com/job/developer-run-tests/1084/

Using the workbench_url value from the discovery document, build wb2's URL and present it as a form to hide the user token.

#8 Updated by Eric Biagiotti 4 months ago

I am testing this by running arvbox, which has workbench and workbench2 running at 172.17.0.2 and 172.17.0.2:3001 respectively.

Do we want this to work locally? If so, #{protocol}://workbench2.#{hostname.split(".")[1..-1].join(".")} produces a bad URL because of the "." parsing.

Also, if I manually fix the generated URL (https://172.17.0.2:3001//token?...), I get the workbench2 loading page on a seemingly infinite loop.

#9 Updated by Lucas Di Pentima 4 months ago

Updates at d1fcb330f
Test run: https://ci.curoverse.com/job/developer-run-tests/1086/

  • Added a workbench2_url config item to workbench, when not false it will make the "Go to Workbench 2" menu item appear on the notification menu.
  • Added test
  • Added config to arvbox script

#10 Updated by Lucas Di Pentima 4 months ago

Just in case you're testing it with arvbox: To get the menu working you should execute "arvbox reboot dev" so that the updated config building script gets into the docker image.

#11 Updated by Eric Biagiotti 4 months ago

Lucas Di Pentima wrote:

Updates at d1fcb330f
Test run: https://ci.curoverse.com/job/developer-run-tests/1086/

  • Added a workbench2_url config item to workbench, when not false it will make the "Go to Workbench 2" menu item appear on the notification menu.
  • Added test
  • Added config to arvbox script

Not sure how we should handle the trailing slash. This is my first venture into ruby and embedded ruby templates but there is a ruby URI module which seems to handle this type of operation. Can this be used here?

What is our policy for correctness of entries in the config file? Does the config get validated somewhere? A URL with a trailing slash is still a valid URL, but should we require no trailing slash?

#12 Updated by Lucas Di Pentima 4 months ago

Updates at 0dbe95af0
Test run: https://ci.curoverse.com/job/developer-run-tests/1091/

  • Added a config validator that disables it if the provided URL is not valid, logging an error message.
  • More test cases added
  • Provided example on the default config file.

#14 Updated by Lucas Di Pentima 4 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

#15 Updated by Tom Morris 4 months ago

  • Release set to 15

Also available in: Atom PDF