Arvados

Updates at 408e81ed6 - branch 14794-link-wb1-to-wb2
Test run: https://ci.curoverse.com/job/developer-run-tests/1084/

Using the workbench_url value from the discovery document, build wb2's URL and present it as a form to hide the user token.

I am testing this by running arvbox, which has workbench and workbench2 running at 172.17.0.2 and 172.17.0.2:3001 respectively.

Do we want this to work locally? If so, #{protocol}://workbench2.#{hostname.split(".")[1..-1].join(".")} produces a bad URL because of the "." parsing.

Also, if I manually fix the generated URL (https://172.17.0.2:3001//token?...), I get the workbench2 loading page on a seemingly infinite loop.

Updates at d1fcb330f
Test run: https://ci.curoverse.com/job/developer-run-tests/1086/

• Added a workbench2_url config item to workbench, when not false it will make the "Go to Workbench 2" menu item appear on the notification menu.
• Added test
• Added config to arvbox script

Just in case you're testing it with arvbox: To get the menu working you should execute "arvbox reboot dev" so that the updated config building script gets into the docker image.

Lucas Di Pentima wrote:

Updates at d1fcb330f
Test run: https://ci.curoverse.com/job/developer-run-tests/1086/

• Added a workbench2_url config item to workbench, when not false it will make the "Go to Workbench 2" menu item appear on the notification menu.
• Added test
• Added config to arvbox script

Not sure how we should handle the trailing slash. This is my first venture into ruby and embedded ruby templates but there is a ruby URI module which seems to handle this type of operation. Can this be used here?

What is our policy for correctness of entries in the config file? Does the config get validated somewhere? A URL with a trailing slash is still a valid URL, but should we require no trailing slash?

Updates at 0dbe95af0
Test run: https://ci.curoverse.com/job/developer-run-tests/1091/

• Added a config validator that disables it if the provided URL is not valid, logging an error message.
• More test cases added
• Provided example on the default config file.

Re-running failed test steps:

• https://ci.curoverse.com/job/developer-run-tests-remainder/1127/
• https://ci.curoverse.com/job/developer-run-tests-apps-workbench-integration/1129/