Story #14841

Link from Workbench 2 to Workbench 1

Added by Tom Morris 10 months ago. Updated 10 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
02/14/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5
Release relationship:
Auto

Subtasks

Task #14843: Review 14841-link-workbench1 in arvados-workbench2ResolvedPeter Amstutz


Related issues

Related to Arvados - Story #14794: Link from Workbench 1 to Workbench 2Resolved02/22/2019

History

#1 Updated by Tom Morris 10 months ago

  • Related to Story #14794: Link from Workbench 1 to Workbench 2 added

#2 Updated by Peter Amstutz 10 months ago

14841-link-workbench1 @ commit:ff8e417f63a58fb1a44ab89ce3c93d1a91828619

Add link to workbench v1

Add a reducer that holds discovery document config, to read workbenchURL & for future things that need cluster config.

Projects, collections and "processes" are routed to equivalent page on wb1, rest are sent to entry page.

#3 Updated by Eric Biagiotti 10 months ago

Currently getting an error when clicking the link (https://workbench.c97qk.arvadosapi.com/projects/9tee4-tpzed-dwg8zzn53khc6ij)

 undefined method `uuid' for nil:NilClass.

Are there some things I need to do in order to test this properly?

Also, it might be worth adding a config-reducer test.

#4 Updated by Peter Amstutz 10 months ago

Eric Biagiotti wrote:

Currently getting an error when clicking the link (https://workbench.c97qk.arvadosapi.com/projects/9tee4-tpzed-dwg8zzn53khc6ij)

[...]

I think that is a workbench bug, but you're running into it because you are not logged in. Now it passes the api_token along so you will be logged into the same account with the same credentials.

Are there some things I need to do in order to test this properly?

Also, it might be worth adding a config-reducer test.

It is so simple, I'm not really sure what to test.

14841-link-workbench1 @ commit:c74d94dabd5f66bc948f9a9ed6283cdb59fb392b

#5 Updated by Eric Biagiotti 10 months ago

Peter Amstutz wrote:

Eric Biagiotti wrote:

Currently getting an error when clicking the link (https://workbench.c97qk.arvadosapi.com/projects/9tee4-tpzed-dwg8zzn53khc6ij)

[...]

I think that is a workbench bug, but you're running into it because you are not logged in. Now it passes the api_token along so you will be logged into the same account with the same credentials.

The link to wb1 now acknowledges that I am logged but gives me an inactive account notification. If this is a separate issue, then this story LGTM.

#6 Updated by Peter Amstutz 10 months ago

Eric Biagiotti wrote:

Peter Amstutz wrote:

Eric Biagiotti wrote:

Currently getting an error when clicking the link (https://workbench.c97qk.arvadosapi.com/projects/9tee4-tpzed-dwg8zzn53khc6ij)

[...]

I think that is a workbench bug, but you're running into it because you are not logged in. Now it passes the api_token along so you will be logged into the same account with the same credentials.

The link to wb1 now acknowledges that I am logged but gives me an inactive account notification. If this is a separate issue, then this story LGTM.

It looks like you logged in as a federated user (from 9tee4) to c97qk, and the federated user is inactive on c97qk. This might actually be a workbench2 bug, because if you are inactive, you can't really do anything, and the workbench2 UI should tell you that. I'll investigate.

#7 Updated by Peter Amstutz 10 months ago

14841-link-workbench1 @ commit:e677489047822fed2dcd48d904ccc46fae5b1615

  • Adds inactive user mode
  • Always reload user record on page initialization, so we don't use stale information (like whether the user is active or not)

#8 Updated by Peter Amstutz 10 months ago

  • Status changed from New to Resolved

#9 Updated by Tom Morris 10 months ago

  • Release set to 15

Also available in: Atom PDF