Bug #14845

[controller] Fix flaky test

Added by Tom Clegg 4 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Tests
Target version:
Start date:
02/15/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

FAIL: handler_test.go:64: HandlerSuite.TestRequestTimeout

handler_test.go:74:
    c.Check(jresp.Errors[0], check.Matches, `.*context deadline exceeded.*`)
    ... value string = "Get https://0.0.0.0:38843/discovery/v1/apis/arvados/v1/rest: net/http: request canceled (Client.Timeout exceeded while awaiting headers)" 
    ... regex string = ".*context deadline exceeded.*" 

OOPS: 49 passed, 1 FAILED
--- FAIL: Test (1.20s)
FAIL
coverage: 83.6% of statements
FAIL      git.curoverse.com/arvados.git/lib/controller  1.250s

Subtasks

Task #14850: Review 14845-fix-flaky-testResolvedPeter Amstutz

Associated revisions

Revision 5f800129
Added by Tom Clegg 4 months ago

Merge branch '14845-fix-flaky-test'

fixes #14845

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

History

#1 Updated by Tom Clegg 4 months ago

"Repeat test suite 99 times" (or even 2) also involved fixing an unrelated leaky test case.

14845-fix-flaky-test @ 9fa65d7621853b24b7fb13acd44fedb28543b261 https://ci.curoverse.com/view/Developer/job/developer-run-tests/1070/

#2 Updated by Tom Clegg 4 months ago

  • Status changed from New to In Progress

#3 Updated by Peter Amstutz 4 months ago

Tom Clegg wrote:

"Repeat test suite 99 times" (or even 2) also involved fixing an unrelated leaky test case.

14845-fix-flaky-test @ 9fa65d7621853b24b7fb13acd44fedb28543b261 https://ci.curoverse.com/view/Developer/job/developer-run-tests/1070/

The tweak to TestUpdateRemoteContainerRequest() that resets the priority to 1 is slightly dodgy since the test don't actually record what the starting priority was. On the other hand, we already make lots of assumptions about the contents of fixtures in our tests, so this isn't really a problem.

LGTM.

#4 Updated by Tom Clegg 4 months ago

  • Status changed from In Progress to Resolved

#5 Updated by Tom Morris 4 months ago

  • Release set to 15

Also available in: Atom PDF