Bug #14845
closed
[controller] Fix flaky test
Description
FAIL: handler_test.go:64: HandlerSuite.TestRequestTimeout
handler_test.go:74:
c.Check(jresp.Errors[0], check.Matches, `.*context deadline exceeded.*`)
... value string = "Get https://0.0.0.0:38843/discovery/v1/apis/arvados/v1/rest: net/http: request canceled (Client.Timeout exceeded while awaiting headers)"
... regex string = ".*context deadline exceeded.*"
OOPS: 49 passed, 1 FAILED
--- FAIL: Test (1.20s)
FAIL
coverage: 83.6% of statements
FAIL git.curoverse.com/arvados.git/lib/controller 1.250s
Updated by Tom Clegg almost 6 years ago
"Repeat test suite 99 times" (or even 2) also involved fixing an unrelated leaky test case.
14845-fix-flaky-test @ 9fa65d7621853b24b7fb13acd44fedb28543b261 https://ci.curoverse.com/view/Developer/job/developer-run-tests/1070/
Updated by Peter Amstutz almost 6 years ago
Tom Clegg wrote:
"Repeat test suite 99 times" (or even 2) also involved fixing an unrelated leaky test case.
14845-fix-flaky-test @ 9fa65d7621853b24b7fb13acd44fedb28543b261 https://ci.curoverse.com/view/Developer/job/developer-run-tests/1070/
The tweak to TestUpdateRemoteContainerRequest() that resets the priority to 1 is slightly dodgy since the test don't actually record what the starting priority was. On the other hand, we already make lots of assumptions about the contents of fixtures in our tests, so this isn't really a problem.
LGTM.
Updated by Tom Clegg almost 6 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|5f8001297500ccd0a2153ede4a28ba14daad0d42.
Updated by Tom Morris