https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422019-02-19T15:59:15ZArvadosArvados - Bug #14860: [API] Cannot modify collection when versioning is enabled and idle time is expiredhttps://dev.arvados.org/issues/14860?journal_id=715242019-02-19T15:59:15ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #14860: [API] Cannot modify collection when versioning is enabled and idle time is expiredhttps://dev.arvados.org/issues/14860?journal_id=715312019-02-19T17:40:45ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>After some more diagnosing, the issue seems to be happening when trying to save the snapshot collection on <code>manage_versioning()</code> callback at <code>Collection</code> class: The <code>check_signatures()</code> callback on the newly created snapshot fails because <code>manifest_text</code> has locators without signatures (fails at line 129)</p> Arvados - Bug #14860: [API] Cannot modify collection when versioning is enabled and idle time is expiredhttps://dev.arvados.org/issues/14860?journal_id=715332019-02-19T18:17:02ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Lucas Di Pentima wrote:</p>
<blockquote>
<p>After some more diagnosing, the issue seems to be happening when trying to save the snapshot collection on <code>manage_versioning()</code> callback at <code>Collection</code> class: The <code>check_signatures()</code> callback on the newly created snapshot fails because <code>manifest_text</code> has locators without signatures (fails at line 129)</p>
</blockquote>
<p>From chat:</p>
<p>The brute force solution would be to call signed_manifest_text to get manifest_text for the snapshot. Alternately you could wrap snapshot.save with act_as_system_user so long as that doesn't change any of the metadata fields (modified_by_user_uuid &c) or other behavior.</p> Arvados - Bug #14860: [API] Cannot modify collection when versioning is enabled and idle time is expiredhttps://dev.arvados.org/issues/14860?journal_id=715442019-02-19T20:08:59ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Updates at <a class="changeset" title="14860: Fixes bug by assigning the signed manifest text to the snapshot being saved. Arvados-DCO-..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/c1e1a754670eadb154fba29817dcd9b7360a4e18">c1e1a7546</a> - branch <code>14860-fix-collection-versioning</code><br />Test run: <a class="external" href="https://ci.curoverse.com/job/developer-run-tests/1077/">https://ci.curoverse.com/job/developer-run-tests/1077/</a></p>
<p>Fixed the bug by assigning the signed manifest text to the snapshot being saved, as suggested by Peter. The <code>act_as_system_user</code> approach didn't worked because the <code>modified_by_user_uuid</code> field was being updated.</p> Arvados - Bug #14860: [API] Cannot modify collection when versioning is enabled and idle time is expiredhttps://dev.arvados.org/issues/14860?journal_id=715452019-02-19T20:18:15ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Lucas Di Pentima wrote:</p>
<blockquote>
<p>Updates at <a class="changeset" title="14860: Fixes bug by assigning the signed manifest text to the snapshot being saved. Arvados-DCO-..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/c1e1a754670eadb154fba29817dcd9b7360a4e18">c1e1a7546</a> - branch <code>14860-fix-collection-versioning</code><br />Test run: <a class="external" href="https://ci.curoverse.com/job/developer-run-tests/1077/">https://ci.curoverse.com/job/developer-run-tests/1077/</a></p>
<p>Fixed the bug by assigning the signed manifest text to the snapshot being saved, as suggested by Peter. The <code>act_as_system_user</code> approach didn't worked because the <code>modified_by_user_uuid</code> field was being updated.</p>
</blockquote>
<p>This LGTM.</p> Arvados - Bug #14860: [API] Cannot modify collection when versioning is enabled and idle time is expiredhttps://dev.arvados.org/issues/14860?journal_id=715472019-02-19T20:27:51ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>23</i></li></ul> Arvados - Bug #14860: [API] Cannot modify collection when versioning is enabled and idle time is expiredhttps://dev.arvados.org/issues/14860?journal_id=715482019-02-19T20:49:29ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset <a class="changeset" title="Merge branch '14860-fix-collection-versioning' Closes #14860 Arvados-DCO-1.1-Signed-off-by: Luca..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/9acc7690b9c734b7e31476ce66ef668bf7eb4bbf">arvados|9acc7690b9c734b7e31476ce66ef668bf7eb4bbf</a>.</p> Arvados - Bug #14860: [API] Cannot modify collection when versioning is enabled and idle time is expiredhttps://dev.arvados.org/issues/14860?journal_id=715872019-02-20T17:54:23ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Release</strong> changed from <i>23</i> to <i>21</i></li></ul>