Arvados

I have a branch of arvbox, I just tried upgrading ruby to 2.4. We might have a problem with the SSO server:

2019-03-13_18:21:07.25233 Bundler::GemRequireError: There was an error while trying to load the gem 'devise'.
2019-03-13_18:21:07.25233 Gem Load Error is: ActiveSupport::Duration can't be coerced into Integer
2019-03-13_18:21:07.25233 Backtrace for gem load error is:
2019-03-13_18:21:07.25233 /var/lib/gems/ruby/2.4.0/gems/activesupport-3.2.22.5/lib/active_support/core_ext/numeric/time.rb:50:in `*'
2019-03-13_18:21:07.25233 /var/lib/gems/ruby/2.4.0/gems/activesupport-3.2.22.5/lib/active_support/core_ext/numeric/time.rb:50:in `days'
2019-03-13_18:21:07.25234 /var/lib/gems/ruby/2.4.0/gems/activesupport-3.2.22.5/lib/active_support/core_ext/numeric/time.rb:55:in `weeks'
2019-03-13_18:21:07.25234 /var/lib/gems/ruby/2.4.0/gems/devise-2.2.8/lib/devise.rb:102:in `<module:Devise>'
2019-03-13_18:21:07.25234 /var/lib/gems/ruby/2.4.0/gems/devise-2.2.8/lib/devise.rb:8:in `<top (required)>'
2019-03-13_18:21:07.25234 /var/lib/gems/gems/bundler-1.16.1/lib/bundler/runtime.rb:81:in `require'
2019-03-13_18:21:07.25234 /var/lib/gems/gems/bundler-1.16.1/lib/bundler/runtime.rb:81:in `block (2 levels) in require'
2019-03-13_18:21:07.25234 /var/lib/gems/gems/bundler-1.16.1/lib/bundler/runtime.rb:76:in `each'
2019-03-13_18:21:07.25235 /var/lib/gems/gems/bundler-1.16.1/lib/bundler/runtime.rb:76:in `block in require'
2019-03-13_18:21:07.25235 /var/lib/gems/gems/bundler-1.16.1/lib/bundler/runtime.rb:65:in `each'
2019-03-13_18:21:07.25235 /var/lib/gems/gems/bundler-1.16.1/lib/bundler/runtime.rb:65:in `require'
2019-03-13_18:21:07.25235 /var/lib/gems/gems/bundler-1.16.1/lib/bundler.rb:114:in `require'
2019-03-13_18:21:07.25236 /usr/src/sso/config/application.rb:7:in `<top (required)>'
2019-03-13_18:21:07.25236 /usr/src/sso/Rakefile:4:in `require'
2019-03-13_18:21:07.25236 /usr/src/sso/Rakefile:4:in `<top (required)>'

@lucas @Peter we were talking on our kanban about the ruby update, why don't we try to go to version 2.5 instead of 2.4 . For Debian (buster)and Ubuntu (bionic) default is 2.5.1 and we think stretch will move to this version also now taht 2.3 is in EOL .

Fernando: Rails 4.2 doesn't support ruby 2.5, BUT rails 4.2 will be completely unsupported near April 30th when rails 6 is released, so I think it's maybe worth to try to upgrade rails & ruby on the same go.

Status update: 0a80a91b9 - branch 14946-ruby-2.5

• Dockerfiles updated to build packages with ruby 2.5.5, except for Ubuntu 14.04 that fails. (investigation pending)
• API tests passing using a stretch image with latest rvm & ruby 2.5.5: https://ci.curoverse.com/view/Developer/job/ruby25-run-tests-services-api/7
• Now running workbench unit tests at https://ci.curoverse.com/view/Developer/job/ruby25-run-tests-services-api/8
• If wb unit test pass, we'll do a full run on the ruby25 jenkins job.

Fernando just launched a full test run (https://ci.curoverse.com/view/Developer/job/ruby25-run-tests-services-api/9) after confirming WB unit test success.

Updated SSO's installation documentation to ask for ruby 2.3, while the rest asks for 2.5 - c4107b1da

Updates at 618643017
Test run: https://ci.curoverse.com/view/Developer/job/ruby25-run-tests-services-api/12

Fixed several warnings regarding un-initialized variables, deprecated Fixnum usage, unused variables, etc.

Updates at ebce50053
Test run: https://ci.curoverse.com/view/Developer/job/ruby25-run-tests-services-api/14/console

Further ruby warning fixes were made.
There are warnings coming from various gems that we use on workbench, some of them don't have newer versions (for example andand), should we invest time on trying to fix them?

Fernando tells me that we shouldn't merge this without confirming with him first, as he's doing some work on Jenkins to be able to support the newer ruby.

Lucas Di Pentima wrote:

Updates at ebce50053

LGTM

There are warnings coming from various gems that we use on workbench, some of them don't have newer versions (for example andand), should we invest time on trying to fix them?

I don't think so. The warnings only show up in dev/test mode, not in production, right?

Fernando tells me that we shouldn't merge this without confirming with him first, as he's doing some work on Jenkins to be able to support the newer ruby.

It doesn't seem like this depends on 2.5 so it should work anyway -- but whatever is easier for Fernando sounds good to me.