https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422019-03-18T17:44:59ZArvadosArvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=725162019-03-18T17:44:59ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=725172019-03-18T17:53:06ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Subject</strong> changed from <i>Attempting to navigate to non-existent path spins forever</i> to <i>Attempting to navigate to non-existent path not handled</i></li><li><strong>Description</strong> updated (<a title="View differences" href="/journals/72517/diff?detail_id=69494">diff</a>)</li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=725182019-03-18T17:53:18ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>New</i></li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=743442019-05-13T14:27:12ZChrystian Klingenberg
<ul><li><strong>Target version</strong> set to <i>Backlog Q1, Q2</i></li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=753362019-06-10T11:56:30ZChrystian Klingenberg
<ul><li><strong>Target version</strong> changed from <i>Backlog Q1, Q2</i> to <i>Workbench2 Q3, Q4</i></li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=755022019-06-13T07:17:09ZChrystian Klingenberg
<ul><li><strong>Subject</strong> changed from <i>Attempting to navigate to non-existent path not handled</i> to <i>[Navigation] Attempting to navigate to non-existent path not handled</i></li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=771102019-08-21T14:54:35ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/77110/diff?detail_id=73784">diff</a>)</li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=800032019-12-31T15:20:00ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>20</i></li><li><strong>Target version</strong> deleted (<del><i>Workbench2 Q3, Q4</i></del>)</li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=827332020-02-27T18:43:21ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> set to <i>2020-03-11 Sprint</i></li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=827342020-02-27T18:44:01ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> deleted (<del><i>20</i></del>)</li><li><strong>Assigned To</strong> set to <i>Piotr Mrzygłowski</i></li><li><strong>Category</strong> set to <i>Workbench2</i></li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=827642020-02-28T14:31:32ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=827702020-02-28T18:43:22ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Supporting this story, I've created the branch <code>14990-support-email-exported-config</code> to add <code>Mail.SupportEmailAddress</code> config to controller's exported config endpoint.<br />Test run: <a class="external" href="https://ci.arvados.org/job/developer-run-tests/1758/"<a href="https://ci.arvados.org/job/developer-run-tests/1758/">developer-run-tests: #1758 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-run-tests&build=1758" alt="" /></a></a></p> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=827722020-02-28T19:24:43ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><ul>
<li>Although the ticket didn’t explained it, I think we need to mimic workbench1’s behavior as much as possible, so I think it would be best to show the “not found” component as a default route instead of doing the redirect, that way the URL isn’t changed.</li>
<li>Also, in the spirit of copying Workbench1’s style, when requesting for a known object type, it should show a message like: The <code><object_type></code> with UUID <code>zzzzz-yyyyyy-xxxxxxxxxxxxxxxx</code> was not found. Perhaps you'd like to browse all <object_type>s? (with a link)</li>
<li>When requesting a trashed project/group or collection, instead of showing a “not found” message, workbench1 shows a message saying it is trashed, the date when the object will be definitely deleted and a button allowing the user to recover it from the trash. See “untrash” method on <a class="external" href="https://doc.arvados.org/v2.0/api/methods/groups.html">https://doc.arvados.org/v2.0/api/methods/groups.html</a> as an example.
<ul>
<li>In the particular case of collections, when accessing to <code>/collections/some-valid-uuid</code>, where <code>some-valid-uuid</code> has the correct format (for example: <code><a href="https://arvadosapi.com/x2jbo-4zz18-xr1ir7qowrj2y2k">x2jbo-4zz18-xr1ir7qowrj2y2k</a></code>) but it doesn’t exist or is trashed, an error toast is being displayed with a 404 message and the UI is blank or partially filled if we’re requesting a previously non-trashed collection. Instead, workbench2 should show a message like the one described for the projects/groups.</li>
<li>Also, when accessing to <code>/collections/not-a-valid-uuid</code>, Workbench2 does a content address search, although workbench1 doesn’t offer the possibility to “untrash" trashed collections by PDH, Workbench2 should have this feature.</li>
</ul>
</li>
<li>On every “not found” page, workbench1 also provides the user the ability to send a message to the admins via a support form or email. The support form is backed by workbench1’s rails application, and we don’t have that capability on workbench2, OTOH we could provide an email link that pre-populates the email with API version number, url being accessed, etc. The admin email should be accessible via the public config endpoint (for example: <a class="external" href="https://ce8i5.arvadosapi.com/arvados/v1/config">https://ce8i5.arvadosapi.com/arvados/v1/config</a>) at the <code>Mail.SupportEmailAddress</code> key. This config key will be available when the branch <code>14990-support-email-exported-config</code> is merged on arvados’ repo.</li>
</ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=829812020-03-11T13:38:37ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2020-03-11 Sprint</i> to <i>2020-03-25 Sprint</i></li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=830922020-03-14T16:09:38ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Assigned To</strong> deleted (<del><i>Piotr Mrzygłowski</i></del>)</li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=831542020-03-18T19:45:50ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>31</i></li><li><strong>Target version</strong> deleted (<del><i>2020-03-25 Sprint</i></del>)</li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=846912020-06-10T18:03:00ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> set to <i>2020-06-17 Sprint</i></li><li><strong>Assigned To</strong> set to <i>Daniel Kutyła</i></li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=847612020-06-15T15:51:15ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/84761/diff?detail_id=81550">diff</a>)</li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=848402020-06-17T15:47:26ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2020-06-17 Sprint</i> to <i>2020-07-01 Sprint</i></li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=850252020-06-24T20:45:40ZDaniel Kutyła
<ul></ul><p>New version: <a class="external" href="https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/dd4004015ae711939d2474dd8c6e031b6be2d0ff">https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/dd4004015ae711939d2474dd8c6e031b6be2d0ff</a><br />Test run: <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/53/"<a href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/53/">developer-tests-workbench2: #53 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=53" alt="" /></a></a></p>
<ul>
<li>Added 404 page with wildcard route</li>
</ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=850332020-06-25T13:03:18ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Reviewing <a class="changeset" title="14990: adds 404 page with wildcard route Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.ku..." href="https://dev.arvados.org/projects/arvados-workbench-2/repository/arvados-workbench2/revisions/dd4004015ae711939d2474dd8c6e031b6be2d0ff">arvados-workbench2|dd40040</a> - branch <code>14990-attempting-to-navigate-to-non-existent-path-not-handled</code></p>
<p>The default routing looks good. What's missing is a link/button that allows the user to send a pre-populated email to the site admin to report an issue, like on Workbench1. You can get the admin's email address from the exported config's <code>Mail.SupportEmailAddress</code> key available at <code>state.auth.config.clusterConfig</code></p> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=851602020-06-29T20:13:08ZDaniel Kutyła
<ul></ul><p>New version: <a class="external" href="https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/51041db20a296235ca14c6cc73f1ff7f1db2c0b7">https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/51041db20a296235ca14c6cc73f1ff7f1db2c0b7</a><br />Version with testfix: <a class="external" href="https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/625e72407ad730e05c1551df3e2919a1a9ffd3e4">https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/625e72407ad730e05c1551df3e2919a1a9ffd3e4</a><br />Test run: <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/56/"<a href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/56/">developer-tests-workbench2: #56 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=56" alt="" /></a></a></p>
<ul>
<li>collection uuid / object hash check and 404 additional notification</li>
<li>unit tests added</li>
</ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=851672020-06-29T21:01:07ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Both test runs failed, have you already tried to run them locally and they're only failing on Jekins?</p> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=852132020-07-01T15:32:09ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> changed from <i>2020-07-01 Sprint</i> to <i>2020-07-15</i></li></ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=852622020-07-02T19:42:56ZDaniel Kutyła
<ul></ul><p>New version (mostly master merge): <a class="external" href="https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/6cab974c8255a413d0714d53dcdf125d869bfc62">https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/6cab974c8255a413d0714d53dcdf125d869bfc62</a></p>
<p>Version with most code changes: <a class="external" href="https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/51041db20a296235ca14c6cc73f1ff7f1db2c0b7">https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/51041db20a296235ca14c6cc73f1ff7f1db2c0b7</a></p>
<p>Test run: <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/60/"<a href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/60/">developer-tests-workbench2: #60 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=60" alt="" /></a></a></p>
<p>collection uuid / object hash check and 404 additional notification<br />unit tests added</p> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=852712020-07-06T14:55:54ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Reviewing <a class="changeset" title="14990: master merge Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors.roch..." href="https://dev.arvados.org/projects/arvados-workbench-2/repository/arvados-workbench2/revisions/70ec54043c81e3612cc4711c1a6b763ba099b44b">arvados-workbench2|70ec540</a></p>
<ul>
<li>File <code>src/views/not-found-panel/not-found-panel-root.tsx</code> - Line 66: repeated ‘us’ word on ‘…email us us if you suspect…’ error message. Also, on its test case.</li>
<li>When the support email address isn’t configured, the link will have an undefined <code>mailto:</code> href. Do you think it would be better to display another message? Like, “The page you requested was not found, contact the site admin if you suspect this is a bug.” this way we save the user the frustration of emailing an inexistent address. (Please add a test for this, too.)</li>
<li>The email link could include additional information so that the user doesn’t need to add it manually. Example: “mailto:<a class="email" href="mailto:admin@example.com">admin@example.com</a>?subject=…&body=…” (Check RFC 2368 to know more). It would be nice to add the following information:
<ul>
<li>User’s uuid trying to access the object</li>
<li>Object being tried to access (PDH/UUID that produced the error)</li>
<li>URL being accessed</li>
<li>Maybe a section header so that the user can add their own notes/comments.</li>
</ul>
</li>
<li>The UUID incorrect format message only works for collections, but we use UUIDs for all types of objects: projects/groups, containers, container requests (aka: processes on wb2), users, etc. </li>
<li>When requesting a collection with a valid but unreachable uuid, the page is blank and a snackbar with a 404 error briefly appears. As described on the ticket’s description, it should show a page with the message "The <code><object_type></code> with UUID <code>zzzzz-yyyyyy-xxxxxxxxxxxxxxxx</code> was not found." </li>
<li>When requesting a project with a valid but unreachable uuid, it seems to display an empty project, and a error snackbar storm starts, we should handle any ‘valid but not found’ uuid object request like the previous point.</li>
<li>Also, make sure no snackbar error message appears when the "not found" cases are handled.</li>
<li>The added unit tests check that the “not found” component renders the correct information. I think a check that the component is used on correct cases is missing. My first thought would be to make an e2e test, but maybe you know a better (faster) way to test that.</li>
<li>Requesting trashed objects doesn’t inform the user that the object being displayed is trashed. I don’t remember if we talked about this on our last call with Peter.</li>
</ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=853652020-07-13T12:59:37ZDaniel Kutyła
<ul></ul><p>New version: <a class="external" href="https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/90460e90dfb2ac4863b133bc477098252f677fea">https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/90460e90dfb2ac4863b133bc477098252f677fea</a><br />Test run: <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/64/"<a href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/64/">developer-tests-workbench2: #64 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=64" alt="" /></a></a></p>
<p>added e2e tests</p> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=853712020-07-13T17:05:52ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Reviewing <a class="changeset" title="14990: failing test fix Arvados-DCO-1.1-Signed-off-by: Daniel Kutyła <daniel.kutyla@contractors...." href="https://dev.arvados.org/projects/arvados-workbench-2/repository/arvados-workbench2/revisions/90460e90dfb2ac4863b133bc477098252f677fea">arvados-workbench2|90460e9</a></p>
<ul>
<li>The email link is being rendered like this:<br /><pre><a class="Component-active-499" href="mailto:mailto:arvados@example.com?body=Problem while viewing page /collections/x2jbo-4zz18-yvzizixe23360u;subject=Workbench problem report">email us</a></pre> The problems I see on it are:
<ul>
<li>Double <code>mailto:</code> scheme.</li>
<li>No url-encoded params' values. Example from wb1:<br /><pre>
<a href="mailto:arvados@example.com?body=Problem%20while%20viewing%20page%20https%3A%2F%2Fworkbench.ce8i5.arvadosapi.com%2Fcollections%2Fce8i5-4zz18-8gkju5htq6mziu&subject=Workbench%20problem%20report">email us</a>
</pre></li>
</ul>
</li>
<li>There’s commented out code at file <code>src/views-components/not-found-dialog/not-found-dialog.tsx</code> line 52.</li>
<li>If the <code>Mail.SupportEmailAddress</code> cluster config value is not set (ie: having an empty string as its value), I think it’s not a good UX to offer the user a <code>mailto:</code> link that won’t work, do you agree? Please add a test checking this.</li>
</ul> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=853912020-07-13T18:27:07ZDaniel Kutyła
<ul></ul><p>New version: <a class="external" href="https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/4badc373d653f27010b01ddb12fb5275e706b666">https://dev.arvados.org/projects/arvados-workbench-2/repository/revisions/4badc373d653f27010b01ddb12fb5275e706b666</a><br />Test run: <a class="external" href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/65/"<a href="https://ci.arvados.org/view/Developer/job/developer-tests-workbench2/65/">developer-tests-workbench2: #65 <img src="https://ci.arvados.org/buildStatus/icon?job=developer-tests-workbench2&build=65" alt="" /></a></a></p>
<p>Fixed double mailto, removed commented code, added tests and email check</p> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=853932020-07-13T18:34:30ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Updates at <a class="changeset" title="14990: removed double mailto, added tests, code cleanup Arvados-DCO-1.1-Signed-off-by: Daniel Ku..." href="https://dev.arvados.org/projects/arvados-workbench-2/repository/arvados-workbench2/revisions/4badc373d653f27010b01ddb12fb5275e706b666">arvados-workbench2|4badc37</a> LGTM, thanks!</p> Arvados Workbench 2 - Bug #14990: [Navigation] Attempting to navigate to non-existent path not handledhttps://dev.arvados.org/issues/14990?journal_id=853972020-07-13T19:52:02ZDaniel Kutyła
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset <a class="changeset" title="Merge branch '14990-attempting-to-navigate-to-non-existent-path-not-handled' Closes #14990 Arvad..." href="https://dev.arvados.org/projects/arvados-workbench-2/repository/arvados-workbench2/revisions/011705a4f293a0f5737c021b1ad2c5c87cd0cb03">arvados-workbench2|011705a4f293a0f5737c021b1ad2c5c87cd0cb03</a>.</p>