Arvados

15028-cwl-v1.1 @ 725ff809bfef3214ca9117b768711c8136ed4cc3

https://ci.curoverse.com/view/Developer/job/developer-run-tests/1264/

15028-cwl-v1.1 @ 9e27319d4ec960e6fac43322b885e8aa355651f9

https://ci.curoverse.com/view/Developer/job/developer-run-tests/1270/

https://ci.curoverse.com/view/CWL/job/arvados-cwl-conformance-tests/147/

No comments on the code, but running:

 ./test_with_arvbox.sh  --no-reset-container --config dev --leave-running --suite conformance-v1.1

All the tests return the following:

The CWL reference runner no longer supports pre CWL v1.0 documents. Supported versions are: 
v1.0
v1.1.0-dev1 (with --enable-dev flag only)

Also, would be nice to be able to pass the -j flag through test_with_arvbox.sh. Should work with both integration and conformance tests.

Eric Biagiotti wrote:

No comments on the code, but running:

[...]

All the tests return the following:

The CWL reference runner no longer supports pre CWL v1.0 documents. Supported versions are:

You need to run test_with_arvbox.sh with "--build" so that it builds a jobs image with the local checkout instead of fetching arvados/jobs:latest.

Also, would be nice to be able to pass the -j flag through test_with_arvbox.sh. Should work with both integration and conformance tests.

That ought to work. Did you try it?

Gave up on running the tests with test_with_arvbox. Maybe we need some better documentation for running that script.

./run_test.sh -j8 RUNNER=arvados-cwl-runner EXTRA="--api=containers --compute-checksum --disable-reuse --local" resulted in the following:

Test 253 failed: /home/eric/projects/cwl_env/venv/bin/arvados-cwl-runner --api=containers --compute-checksum --disable-reuse --local --outdir=/tmp/tmpZhRx2l --quiet tests/optional-numerical-output-0.cwl tests/empty.json
Test that optional number output is returned as 0, not null

Compare failure expected: {
    "out": 0
}
got: {
    "out": null
}
caused by: failed comparison for key 'out': expected: 0
got: null
250 tests passed, 1 failures, 2 unsupported features

Documentation branch: 15028-cwl11-doc-update @ b23721a01f61c6d9862ea6cb4d15bd620e06eeef

Peter Amstutz wrote:

Documentation branch: 15028-cwl11-doc-update @ b23721a01f61c6d9862ea6cb4d15bd620e06eeef

• Remove "this" in:

  The one exception to the @hints@ section this is @arv:APIRequirement@

• Would be nice to link back to the API Requirement extension from the reference to it in the cwl workflow tutorial

• The Portability section in cwl-style.html:
  • The first sentence seems like it should go above the portability section
  • The subsequent sentences kind of come out of no where. Maybe a lead in sentence about why portability is important would help, or "Consider the following recommendations to improve portability of your workflows...".
  • The tip to Avoid declaring InlineJavascriptRequirement is a performance problem and should probably be in the performance section.

• I think a separate page for Upgrading CWL might be helpful going forward. At the very least it shouldn't be a subsection under Portability.

This LGTM. Thanks!