Arvados

15133-remove-jobs-api @ a8aa509cf3913c8dc91640ddcad6b25e6609517a

https://ci.curoverse.com/job/developer-run-tests/1462/

https://ci.curoverse.com/view/CWL/job/arvados-cwl-conformance-tests/213/

I removed some more stuff.

15133-remove-jobs-api @ fec7796668a4f4a73bb52e16e13e4504f76649f5

https://ci.curoverse.com/view/Developer/job/developer-run-tests/1466/

https://ci.curoverse.com/view/CWL/job/arvados-cwl-conformance-tests/215/

• There’re some unit tests that we might be able to remove in tandem with some model methods, for example Jobs & PipelineInstances’ cancel methods+tests. How about avoiding create/delete/updates at the model level?
• If the above comment is valid, I think we can remove from lib/config several config entries, like Containers.JobsAPI.DefaultDockerImage, Containers.JobsAPI.ReuseJobIfOutputsDiffer, etc.
• On the docs, there’s a “Job API” section that could be removed/updated at doc/api/execution.html.textile.liquid line 53.
• Doc file doc/sdk/cli/subcommands.html.textile.liquid (line 344) talks about arv-run-pipeline-instance, if that sub-command doesn’t exist anymore, could this section be removed?
• Running git grep arv-run-pipeline-instance on the repo’s root dir reveals some other places where seem to be expected to exist.
• Doing the same as above with “crunch-job” also seem to show that it’s expected to exist for arvbox, and maybe a couple of Dockerfiles?

Lucas Di Pentima wrote:

• There’re some unit tests that we might be able to remove in tandem with some model methods, for example Jobs & PipelineInstances’ cancel methods+tests. How about avoiding create/delete/updates at the model level?
• If the above comment is valid, I think we can remove from lib/config several config entries, like Containers.JobsAPI.DefaultDockerImage, Containers.JobsAPI.ReuseJobIfOutputsDiffer, etc.

Great idea! I was able to remove another whole batch of tests that don't make sense if create/update is disabled.

• On the docs, there’s a “Job API” section that could be removed/updated at doc/api/execution.html.textile.liquid line 53.

Removed it.

• Doc file doc/sdk/cli/subcommands.html.textile.liquid (line 344) talks about arv-run-pipeline-instance, if that sub-command doesn’t exist anymore, could this section be removed?

Removed it.

• Running git grep arv-run-pipeline-instance on the repo’s root dir reveals some other places where seem to be expected to exist.

Thanks, I cleaned those up as well.

• Doing the same as above with “crunch-job” also seem to show that it’s expected to exist for arvbox, and maybe a couple of Dockerfiles?

Removed crunch-dispatch (v1) from arvbox.

15133-remove-jobs-api @ 043185f6d16dd41135c255f0f36fb8a75203537b

https://ci.curoverse.com/job/developer-run-tests/1469/

https://ci.curoverse.com/view/CWL/job/arvados-cwl-conformance-tests/217/

The "integration" part of arvados-cwl-conformance-tests seem to be failing regularly. However they pass when I run them locally. I'm not quite sure what is going on. Unfortunately, since the test runs in a container on an ephemeral compute node, there isn't any additional information to track down the failures.

15133-remove-jobs-api @ 52cfc5c943a591d4f8095794820b72b697ae6f12

https://ci.curoverse.com/job/developer-run-tests/1470/

This LGTM, except for the fact that when trying out a previously created arvbox with current master (but using an image from this dev branch), I got the following error when trying to start the api:

[...]
2019-08-09_23:44:25.85307 + mkdir -p tmp/cache
2019-08-09_23:44:25.85830 + bundle exec rake db:migrate
2019-08-09_23:44:34.52979 time="2019-08-09T23:44:34.529692101Z" level=warning msg="deprecated or unknown config entry: Clusters.x3o8s.NodeProfiles" 
2019-08-09_23:44:36.18151 rake aborted!
2019-08-09_23:44:36.18155 NameError: uninitialized constant CommitAncestor
2019-08-09_23:44:36.18173 /var/lib/gems/ruby/2.3.0/gems/activesupport-5.0.7.2/lib/active_support/inflector/methods.rb:268:in `const_get'
2019-08-09_23:44:36.18174 /var/lib/gems/ruby/2.3.0/gems/activesupport-5.0.7.2/lib/active_support/inflector/methods.rb:268:in `block in constantize'
2019-08-09_23:44:36.18174 /var/lib/gems/ruby/2.3.0/gems/activesupport-5.0.7.2/lib/active_support/inflector/methods.rb:266:in `each'
2019-08-09_23:44:36.18174 /var/lib/gems/ruby/2.3.0/gems/activesupport-5.0.7.2/lib/active_support/inflector/methods.rb:266:in `inject'
2019-08-09_23:44:36.18175 /var/lib/gems/ruby/2.3.0/gems/activesupport-5.0.7.2/lib/active_support/inflector/methods.rb:266:in `constantize'
[...]

Not sure if this also will happen when upgrading other systems.