Project

General

Profile

Actions

Idea #15181

closed

[cwl] Remove support for jobs api in a-c-r

Added by Peter Amstutz almost 5 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Story points:
1.0
Release relationship:
Auto

Description

Remove jobs API support in a-c-r and use containers API by default. The --api argument should remain valid but only accept 'containers'.

delete jobs api tests.

migrate the unit test test_overall_resource_singlecontainer to test_container.


Subtasks 1 (0 open1 closed)

Task #15507: Review 15181-remove-acr-jobs-supportResolvedPeter Amstutz08/06/2019Actions

Related issues

Blocks Arvados - Idea #15133: Remove crunch v1 (jobs api)ResolvedPeter Amstutz08/08/2019Actions
Actions #1

Updated by Peter Amstutz almost 5 years ago

  • Related to Idea #15133: Remove crunch v1 (jobs api) added
Actions #2

Updated by Peter Amstutz almost 5 years ago

  • Description updated (diff)
Actions #3

Updated by Peter Amstutz almost 5 years ago

  • Description updated (diff)
Actions #4

Updated by Peter Amstutz almost 5 years ago

  • Description updated (diff)
Actions #5

Updated by Tom Morris almost 5 years ago

  • Target version changed from To Be Groomed to Arvados Future Sprints
  • Story points set to 1.0
Actions #6

Updated by Tom Morris almost 5 years ago

  • Related to deleted (Idea #15133: Remove crunch v1 (jobs api))
Actions #7

Updated by Tom Morris almost 5 years ago

  • Blocks Idea #15133: Remove crunch v1 (jobs api) added
Actions #8

Updated by Peter Amstutz over 4 years ago

  • Target version changed from Arvados Future Sprints to 2019-08-14 Sprint
Actions #9

Updated by Peter Amstutz over 4 years ago

  • Assigned To set to Peter Amstutz
Actions #11

Updated by Lucas Di Pentima over 4 years ago

Some minor comments:

  • Some documentation might need updating, for example: https://doc.arvados.org/user/cwl/cwl-run-options.html (and maybe the upgrade notes?)
  • File executor.py:L400 — There’re a number of error messages mentioning "—api=jobs" that I think they’re no longer valid
  • File __init__.py
    • Lines 99 & 102 also mentions the job api in argument help messages.
    • Lines 157, 160 & 188 make the clarification that some argument are “containers api only”, this is no longer needed IMO
    • Line 300’s code comment references ArvadosJob.done()
Actions #12

Updated by Peter Amstutz over 4 years ago

Lucas Di Pentima wrote:

Some minor comments:

  • Some documentation might need updating, for example: https://doc.arvados.org/user/cwl/cwl-run-options.html (and maybe the upgrade notes?)
  • File executor.py:L400 — There’re a number of error messages mentioning "—api=jobs" that I think they’re no longer valid
  • File __init__.py
    • Lines 99 & 102 also mentions the job api in argument help messages.
    • Lines 157, 160 & 188 make the clarification that some argument are “containers api only”, this is no longer needed IMO
    • Line 300’s code comment references ArvadosJob.done()

Removed some more references to jobs API.

I'm going to spend more time updating the documentation on ticket #15133

15181-remove-acr-jobs-support @ 9a02d4117bfc1372ce5b6baedc9303f2500b3197

https://ci.curoverse.com/job/developer-run-tests/1454/

https://ci.curoverse.com/view/CWL/job/arvados-cwl-conformance-tests/209/

Actions #13

Updated by Lucas Di Pentima over 4 years ago

Providing that the tests pass, this LGTM. Thanks!

Actions #15

Updated by Peter Amstutz over 4 years ago

  • Status changed from New to Resolved
Actions #16

Updated by Peter Amstutz about 4 years ago

  • Release set to 22
Actions

Also available in: Atom PDF