Story #15181

[cwl] Remove support for jobs api in a-c-r

Added by Peter Amstutz 5 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
08/06/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
1.0

Description

Remove jobs API support in a-c-r and use containers API by default. The --api argument should remain valid but only accept 'containers'.

delete jobs api tests.

migrate the unit test test_overall_resource_singlecontainer to test_container.


Subtasks

Task #15507: Review 15181-remove-acr-jobs-supportResolvedPeter Amstutz


Related issues

Blocks Arvados - Story #15133: Remove crunch v1 (jobs api)Resolved08/08/2019

Associated revisions

Revision 07d92519
Added by Peter Amstutz about 1 month ago

Merge branch '15181-remove-acr-jobs-support' refs #15181

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

History

#1 Updated by Peter Amstutz 5 months ago

  • Related to Story #15133: Remove crunch v1 (jobs api) added

#2 Updated by Peter Amstutz 5 months ago

  • Description updated (diff)

#3 Updated by Peter Amstutz 5 months ago

  • Description updated (diff)

#4 Updated by Peter Amstutz 5 months ago

  • Description updated (diff)

#5 Updated by Tom Morris 5 months ago

  • Target version changed from To Be Groomed to Arvados Future Sprints
  • Story points set to 1.0

#6 Updated by Tom Morris 4 months ago

  • Related to deleted (Story #15133: Remove crunch v1 (jobs api))

#7 Updated by Tom Morris 4 months ago

#8 Updated by Peter Amstutz about 2 months ago

  • Target version changed from Arvados Future Sprints to 2019-08-14 Sprint

#9 Updated by Peter Amstutz about 2 months ago

  • Assigned To set to Peter Amstutz

#11 Updated by Lucas Di Pentima about 2 months ago

Some minor comments:

  • Some documentation might need updating, for example: https://doc.arvados.org/user/cwl/cwl-run-options.html (and maybe the upgrade notes?)
  • File executor.py:L400 — There’re a number of error messages mentioning "—api=jobs" that I think they’re no longer valid
  • File __init__.py
    • Lines 99 & 102 also mentions the job api in argument help messages.
    • Lines 157, 160 & 188 make the clarification that some argument are “containers api only”, this is no longer needed IMO
    • Line 300’s code comment references ArvadosJob.done()

#12 Updated by Peter Amstutz about 1 month ago

Lucas Di Pentima wrote:

Some minor comments:

  • Some documentation might need updating, for example: https://doc.arvados.org/user/cwl/cwl-run-options.html (and maybe the upgrade notes?)
  • File executor.py:L400 — There’re a number of error messages mentioning "—api=jobs" that I think they’re no longer valid
  • File __init__.py
    • Lines 99 & 102 also mentions the job api in argument help messages.
    • Lines 157, 160 & 188 make the clarification that some argument are “containers api only”, this is no longer needed IMO
    • Line 300’s code comment references ArvadosJob.done()

Removed some more references to jobs API.

I'm going to spend more time updating the documentation on ticket #15133

15181-remove-acr-jobs-support @ 9a02d4117bfc1372ce5b6baedc9303f2500b3197

https://ci.curoverse.com/job/developer-run-tests/1454/

https://ci.curoverse.com/view/CWL/job/arvados-cwl-conformance-tests/209/

#13 Updated by Lucas Di Pentima about 1 month ago

Providing that the tests pass, this LGTM. Thanks!

#15 Updated by Peter Amstutz about 1 month ago

  • Status changed from New to Resolved

Also available in: Atom PDF