Actions
Story #15181
closed
[cwl] Remove support for jobs api in a-c-r
Start date:
08/06/2019
Due date:
% Done:
100%
Estimated time:
(Total: 0.00 h)
Story points:
1.0
Release:
Release relationship:
Auto
Description
Remove jobs API support in a-c-r and use containers API by default. The --api argument should remain valid but only accept 'containers'.
delete jobs api tests.
migrate the unit test test_overall_resource_singlecontainer to test_container.
Related issues
Updated by Peter Amstutz about 4 years ago
- Related to Story #15133: Remove crunch v1 (jobs api) added
Updated by Tom Morris about 4 years ago
- Target version changed from To Be Groomed to Arvados Future Sprints
- Story points set to 1.0
Updated by Tom Morris about 4 years ago
- Related to deleted (Story #15133: Remove crunch v1 (jobs api))
Updated by Tom Morris about 4 years ago
- Blocks Story #15133: Remove crunch v1 (jobs api) added
Updated by Peter Amstutz almost 4 years ago
- Target version changed from Arvados Future Sprints to 2019-08-14 Sprint
Updated by Peter Amstutz almost 4 years ago
Updated by Lucas Di Pentima almost 4 years ago
Some minor comments:
- Some documentation might need updating, for example: https://doc.arvados.org/user/cwl/cwl-run-options.html (and maybe the upgrade notes?)
- File
executor.py:L400— There’re a number of error messages mentioning "—api=jobs" that I think they’re no longer valid - File
__init__.py- Lines 99 & 102 also mentions the job api in argument help messages.
- Lines 157, 160 & 188 make the clarification that some argument are “containers api only”, this is no longer needed IMO
- Line 300’s code comment references
ArvadosJob.done()
Updated by Peter Amstutz almost 4 years ago
Lucas Di Pentima wrote:
Some minor comments:
- Some documentation might need updating, for example: https://doc.arvados.org/user/cwl/cwl-run-options.html (and maybe the upgrade notes?)
- File
executor.py:L400— There’re a number of error messages mentioning "—api=jobs" that I think they’re no longer valid- File
__init__.py
- Lines 99 & 102 also mentions the job api in argument help messages.
- Lines 157, 160 & 188 make the clarification that some argument are “containers api only”, this is no longer needed IMO
- Line 300’s code comment references
ArvadosJob.done()
Removed some more references to jobs API.
I'm going to spend more time updating the documentation on ticket #15133
15181-remove-acr-jobs-support @ 9a02d4117bfc1372ce5b6baedc9303f2500b3197
https://ci.curoverse.com/job/developer-run-tests/1454/
https://ci.curoverse.com/view/CWL/job/arvados-cwl-conformance-tests/209/
Updated by Lucas Di Pentima almost 4 years ago
Providing that the tests pass, this LGTM. Thanks!
Updated by Peter Amstutz almost 4 years ago
- Status changed from New to Resolved
Actions