Bug #15227: [API][Workbench] Adding tags via workbench1's tag editor saves the JSON string to properties - Arvados

Actions

Copy link

Bug #15227

closed

[API][Workbench] Adding tags via workbench1's tag editor saves the JSON string to properties

Added by Lucas Di Pentima over 5 years ago. Updated over 5 years ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Lucas Di Pentima

Category:

Target version:

2019-05-22 Sprint

Story points:

Release:

Arvados v1.4 - Q1/Q2 2019

Release relationship:

Auto

Description

When viewing a collection with previosly saved tags, they're rendered ok on the editor, but when saving changes/new tags, the API server is saving them as a json string, for example:

...
properties: "{\"tagName\":\"tagValue\"}" 
...

This happens with the rails 5.0 api server and both rails 4.2 & 5.0 workbench1. OTOH, editing the collection with arv edit and manually setting the properties field works ok.

Subtasks 1 (0 open — 1 closed)

Actions

Copy link

Updated by Tom Clegg over 5 years ago

If the database has a json-encoded string (instead of a json-encoded hash) then it seems we have at least two bugs:

apiserver is allowing non-objects into the properties field(s) -- if it's allowing clients to store strings, it might be allowing false, [], and null too
apiserver is not decoding json-encoded parameters supplied by workbench (I'm guessing the problem is apiserver failing to decode, rather than workbench double-encoding, just because ISTR request parsing changed in the rails5 upgrade)

Actions

Copy link