Bug #15295

[a-c-r] keep: reference validation

Added by Peter Amstutz 3 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
06/17/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

This keep reference is invalid, but a-c-r validation doesn't catch it:

keep:/ffffffffffffffffffffffffffffffff+999/ABC123.fastq.gz

In addition, this is an invalid mount request, and the API server doesn't catch it either:

"mounts": {
  "keep:/ffffffffffffffffffffffffffffffff+999": { ... }
}

As a result, the container gets stuck in a start-fail loop. Issue #11561 (included in Arvados 1.4) limits the number of retries, but earlier versions would loop forever.


Subtasks

Task #15326: Review 15295-keep-ref-checkResolvedEric Biagiotti

Associated revisions

Revision a1c4ece1
Added by Peter Amstutz 2 months ago

Merge branch '15295-keep-ref-check' closes #15295

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

History

#1 Updated by Peter Amstutz 3 months ago

  • Description updated (diff)

#2 Updated by Peter Amstutz 3 months ago

  • Description updated (diff)

#3 Updated by Peter Amstutz 3 months ago

  • Target version changed from 2019-06-05 Sprint to 2019-06-19 Sprint

#4 Updated by Peter Amstutz 3 months ago

  • Assigned To set to Peter Amstutz
  • Status changed from New to In Progress

#5 Updated by Peter Amstutz 3 months ago

  • Status changed from In Progress to New

#6 Updated by Ward Vandewege 3 months ago

  • Release set to 22

#7 Updated by Peter Amstutz 2 months ago

15295-keep-ref-check @ ee655972c729a727b56e1dd302a025dd96ad1aa7

Fixes two bugs.

  • Fixes the API server so that changing the state of a container with an update() request correctly increments / checks lock_count
  • Adds validation to keep references in arvados-cwl-runner pathmapper
  • Adds cwl integration test for bad keep reference

https://ci.curoverse.com/view/Developer/job/developer-run-tests/1318/

#8 Updated by Peter Amstutz 2 months ago

  • Status changed from New to In Progress

#9 Updated by Peter Amstutz 2 months ago

  • Target version changed from 2019-06-19 Sprint to 2019-07-03 Sprint

#10 Updated by Peter Amstutz 2 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved

Also available in: Atom PDF