Project

General

Profile

Actions

Bug #15295

closed

[a-c-r] keep: reference validation

Added by Peter Amstutz over 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
06/17/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

This keep reference is invalid, but a-c-r validation doesn't catch it:

keep:/ffffffffffffffffffffffffffffffff+999/ABC123.fastq.gz

In addition, this is an invalid mount request, and the API server doesn't catch it either:

"mounts": {
  "keep:/ffffffffffffffffffffffffffffffff+999": { ... }
}

As a result, the container gets stuck in a start-fail loop. Issue #11561 (included in Arvados 1.4) limits the number of retries, but earlier versions would loop forever.


Subtasks 1 (0 open1 closed)

Task #15326: Review 15295-keep-ref-checkResolvedEric Biagiotti06/17/2019

Actions
Actions #1

Updated by Peter Amstutz over 3 years ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz over 3 years ago

  • Description updated (diff)
Actions #3

Updated by Peter Amstutz over 3 years ago

  • Target version changed from 2019-06-05 Sprint to 2019-06-19 Sprint
Actions #4

Updated by Peter Amstutz over 3 years ago

  • Status changed from New to In Progress
  • Assigned To set to Peter Amstutz
Actions #5

Updated by Peter Amstutz over 3 years ago

  • Status changed from In Progress to New
Actions #6

Updated by Ward Vandewege over 3 years ago

  • Release set to 22
Actions #7

Updated by Peter Amstutz over 3 years ago

15295-keep-ref-check @ ee655972c729a727b56e1dd302a025dd96ad1aa7

Fixes two bugs.

  • Fixes the API server so that changing the state of a container with an update() request correctly increments / checks lock_count
  • Adds validation to keep references in arvados-cwl-runner pathmapper
  • Adds cwl integration test for bad keep reference

https://ci.curoverse.com/view/Developer/job/developer-run-tests/1318/

Actions #8

Updated by Peter Amstutz over 3 years ago

  • Status changed from New to In Progress
Actions #9

Updated by Peter Amstutz over 3 years ago

  • Target version changed from 2019-06-19 Sprint to 2019-07-03 Sprint
Actions #10

Updated by Peter Amstutz over 3 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100
Actions #11

Updated by Tom Morris about 3 years ago

  • Release changed from 22 to 27

Needed for Python 3 support in 1.4.2

Actions #12

Updated by Tom Morris about 3 years ago

  • Release changed from 27 to 22

Never mind. I was given a bad ticket # and didn't verify it. #14965 is the Python 3 story for arv-mount and it didn't make the 1.4 release.

Actions

Also available in: Atom PDF