https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422019-06-26T16:49:13ZArvadosArvados - Bug #15422: Update provenance/used_by endpoint to support containers and documenthttps://dev.arvados.org/issues/15422?journal_id=759202019-06-26T16:49:13ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Target version</strong> changed from <i>2019-07-03 Sprint</i> to <i>2019-07-17 Sprint</i></li></ul> Arvados - Bug #15422: Update provenance/used_by endpoint to support containers and documenthttps://dev.arvados.org/issues/15422?journal_id=760602019-07-03T15:35:45ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Peter Amstutz</i></li></ul> Arvados - Bug #15422: Update provenance/used_by endpoint to support containers and documenthttps://dev.arvados.org/issues/15422?journal_id=761462019-07-09T18:55:59ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>The provenance/used_by methods haven't been updated for containers, meaning they don't return particularly useful results. We should either postpone or expand the scope of this story to include updating adding traversal of containers in the provenance graph.</p> Arvados - Bug #15422: Update provenance/used_by endpoint to support containers and documenthttps://dev.arvados.org/issues/15422?journal_id=761532019-07-09T20:29:11ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Subject</strong> changed from <i>Document collections provenance method</i> to <i>Update provenance/used_by endpoint to support containers and document</i></li><li><strong>Story points</strong> set to <i>1.0</i></li></ul> Arvados - Bug #15422: Update provenance/used_by endpoint to support containers and documenthttps://dev.arvados.org/issues/15422?journal_id=762752019-07-12T18:42:34ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>15422-collections-prov-doc @ <a class="changeset" title="15422: Add provenance and used_by to collection API doc Arvados-DCO-1.1-Signed-off-by: Peter Ams..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/b26a7ca6d495377344fc425e0c8e93275abef575">b26a7ca6d495377344fc425e0c8e93275abef575</a></p>
<ul>
<li>Update provenance and used_by feature on API server to traverse containers/container requests</li>
<li>Update workbench rendering
<ul>
<li>handle containers/container requests</li>
<li>use left-right layout for collections (works better visually when there are large fanouts)</li>
<li>rework container request rendering so it isn't so much of a special case</li>
<li>don't render extra items that are not part of the provenance graph.</li>
</ul></li>
</ul>
<p><a class="external" href="https://ci.curoverse.com/view/Developer/job/developer-run-tests/1391/">https://ci.curoverse.com/view/Developer/job/developer-run-tests/1391/</a></p> Arvados - Bug #15422: Update provenance/used_by endpoint to support containers and documenthttps://dev.arvados.org/issues/15422?journal_id=762842019-07-15T13:44:44ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Bug #15422: Update provenance/used_by endpoint to support containers and documenthttps://dev.arvados.org/issues/15422?journal_id=762922019-07-15T18:39:27ZEric Biagiotti
<ul></ul><ul>
<li>Looks like the test run has actual broken workbench tests. </li>
<li>In the documentation, can we be more specific about what the attributes belong to? i.e. instead of <code>(via "output_uuid" or “log_uuid”)</code> maybe <code>(via the “output_uuid” or “log_uuid" attributes of the container request)</code>? It also would be more clear if the attributes were highlighted.</li>
<li>Shouldn't the following line be outside the <code>if</code> like it is for ContainerRequests above: <a class="source" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/b26a7ca6d495377344fc425e0c8e93275abef575/entry/services/api/app/controllers/arvados/v1/collections_controller.rb#L246">source:services/api/app/controllers/arvados/v1/collections_controller.rb@b26a7ca6d495377344fc425e0c8e93275abef575#L246</a></li>
</ul> Arvados - Bug #15422: Update provenance/used_by endpoint to support containers and documenthttps://dev.arvados.org/issues/15422?journal_id=763392019-07-16T17:56:51ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Eric Biagiotti wrote:</p>
<blockquote>
<ul>
<li>Looks like the test run has actual broken workbench tests.</li>
</ul>
</blockquote>
<p>Fixed. Thanks for pointing that out.</p>
<blockquote>
<ul>
<li>In the documentation, can we be more specific about what the attributes belong to? i.e. instead of <code>(via "output_uuid" or “log_uuid”)</code> maybe <code>(via the “output_uuid” or “log_uuid" attributes of the container request)</code>? It also would be more clear if the attributes were highlighted.</li>
</ul>
</blockquote>
<p>Done.</p>
<blockquote>
<ul>
<li>Shouldn't the following line be outside the <code>if</code> like it is for ContainerRequests above: <a class="source" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/b26a7ca6d495377344fc425e0c8e93275abef575/entry/services/api/app/controllers/arvados/v1/collections_controller.rb#L246">source:services/api/app/controllers/arvados/v1/collections_controller.rb@b26a7ca6d495377344fc425e0c8e93275abef575#L246</a></li>
</ul>
</blockquote>
<p>No. That's because when searching "up" (provenance) it searches by uuid but when it is searching "down" (used by) it searches by portable data hash. If that line was outside the if statement, the collection would be added twice, once by uuid and again by pdh.</p>
<p>15422-collections-prov-doc @ <a class="changeset" title="15422: highlight output/log/mount/container_image Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/508f13840841afc5938f7210a999ff58f002b29d">508f13840841afc5938f7210a999ff58f002b29d</a></p>
<p><a class="external" href="https://ci.curoverse.com/view/Developer/job/developer-run-tests/1399/">https://ci.curoverse.com/view/Developer/job/developer-run-tests/1399/</a></p> Arvados - Bug #15422: Update provenance/used_by endpoint to support containers and documenthttps://dev.arvados.org/issues/15422?journal_id=763422019-07-16T18:30:46ZEric Biagiotti
<ul></ul><p>Thanks, all the tests pass now. This LGTM!</p> Arvados - Bug #15422: Update provenance/used_by endpoint to support containers and documenthttps://dev.arvados.org/issues/15422?journal_id=763512019-07-16T20:07:23ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul> Arvados - Bug #15422: Update provenance/used_by endpoint to support containers and documenthttps://dev.arvados.org/issues/15422?journal_id=811442020-01-22T14:18:01ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>22</i></li></ul>