Story #15424

Make the welcome/login page configurable

Added by Tom Morris 10 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Start date:
10/10/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
2.0
Release relationship:
Auto

Description

This will be uses base URL which can be extended to provide access to a tree of HTML snippets for the Welcome page and which also can be used for theInactive User page, etc.


Subtasks

Arvados - Task #15708: Review 15424-wb2-welcome-pageResolvedPeter Amstutz


Related issues

Related to Arvados Workbench 2 - Feature #13936: [Workbench] Modal after first log in (Steps for registration)Resolved10/28/2019

Associated revisions

Revision 5df95741
Added by Peter Amstutz 6 months ago

Merge branch '15424-wb2-welcome-page' refs #15424

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

History

#1 Updated by Tom Morris 10 months ago

  • Subject changed from Provide a configuration setting for replaceable UI snippets to Make the welcome/login page configurable
  • Description updated (diff)

#2 Updated by Tom Morris 10 months ago

  • Story points set to 2.0

#3 Updated by Tom Morris 10 months ago

  • Related to Feature #13936: [Workbench] Modal after first log in (Steps for registration) added

#4 Updated by Tom Morris 7 months ago

  • Target version set to 2019-10-09 Sprint

#5 Updated by Tom Morris 7 months ago

  • Target version changed from 2019-10-09 Sprint to 2019-10-23 Sprint

#6 Updated by Tom Morris 7 months ago

  • Assigned To set to Tom Morris

#7 Updated by Tom Morris 6 months ago

  • Assigned To changed from Tom Morris to Peter Amstutz

#8 Updated by Peter Amstutz 6 months ago

arvados repo:

15424-wb2-welcome-page @ commit:9d2cf97c13005304f0a9031fd5d88ac89906bb33

wb2 repo:

15424-wb2-welcome-page @ badcb86fb7d0e2ab87c7dcef230072db2e2ae95e

  • Add WelcomePageHTML to configuration
  • Incorporate contents of WelcomePageHTML into login panel

#9 Updated by Eric Biagiotti 6 months ago

Peter Amstutz wrote:

arvados repo:

15424-wb2-welcome-page @ commit:9d2cf97c13005304f0a9031fd5d88ac89906bb33

wb2 repo:

15424-wb2-welcome-page @ badcb86fb7d0e2ab87c7dcef230072db2e2ae95e

  • Add WelcomePageHTML to configuration
  • Incorporate contents of WelcomePageHTML into login panel
  • login-panel.tsx has some commented out code.
  • Is there potential for an admin to inadvertently add HTML that creates an XSS issue? I am not familiar enough with XSS to know for sure, but I'm seeing recommendations to use https://github.com/cure53/DOMPurify when using dangerouslySetInnerHtml.

#10 Updated by Peter Amstutz 6 months ago

Eric Biagiotti wrote:

Peter Amstutz wrote:

arvados repo:

15424-wb2-welcome-page @ commit:9d2cf97c13005304f0a9031fd5d88ac89906bb33

wb2 repo:

15424-wb2-welcome-page @ badcb86fb7d0e2ab87c7dcef230072db2e2ae95e

  • Add WelcomePageHTML to configuration
  • Incorporate contents of WelcomePageHTML into login panel
  • login-panel.tsx has some commented out code.

Removed the commented lines.

  • Is there potential for an admin to inadvertently add HTML that creates an XSS issue? I am not familiar enough with XSS to know for sure, but I'm seeing recommendations to use https://github.com/cure53/DOMPurify when using dangerouslySetInnerHtml.

XSS would definitely be a problem if arbitrary users were providing HTML that will be injected into the page. In this case, only the admin can specify the HTML, so I don't think there is much to be gained by sanitizing it. If the admin wants to include a script tag in the login page, we should probably let them.

#11 Updated by Eric Biagiotti 6 months ago

  • With the current text, there is one line that makes it below the arvados image, which doesn't look great.
  • If you decrease the browser size, eventually the text goes right to the edge. Some padding there would look better.

#12 Updated by Peter Amstutz 6 months ago

Eric Biagiotti wrote:

  • With the current text, there is one line that makes it below the arvados image, which doesn't look great.

- Float the image right instead of left (arvados repo)

15424-wb2-welcome-page @ commit:55ae59fab1e7fe21b51ab8ffb67fcebc2a64f138

  • If you decrease the browser size, eventually the text goes right to the edge. Some padding there would look better.

- Add a margin (wb2 repo)

15424-wb2-welcome-page @ 0bdf4669744c1ad68507a158bca8285e672399ab

#13 Updated by Eric Biagiotti 6 months ago

Peter Amstutz wrote:

Eric Biagiotti wrote:

  • With the current text, there is one line that makes it below the arvados image, which doesn't look great.

- Float the image right instead of left (arvados repo)

15424-wb2-welcome-page @ commit:55ae59fab1e7fe21b51ab8ffb67fcebc2a64f138

  • If you decrease the browser size, eventually the text goes right to the edge. Some padding there would look better.

- Add a margin (wb2 repo)

15424-wb2-welcome-page @ 0bdf4669744c1ad68507a158bca8285e672399ab

This LGTM, thanks!

#14 Updated by Peter Amstutz 6 months ago

  • Status changed from New to Resolved

#15 Updated by Peter Amstutz 3 months ago

  • Release set to 22

Also available in: Atom PDF