Bug #15496

[Workbench] Group membership doesn't work on User admin page

Added by Lucas Di Pentima 5 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench
Target version:
Start date:
07/26/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

When clicking user → group or group → user checkboxes, no request is being made to the server. On the Javascript console there's an error that can provide some clue:

0: "Error: no data-permission-uuid established here." 
1: input#group_uuids_
length: 2
__proto__: Array(0)

Subtasks

Task #15498: Review 15496-wb1-group-membership-adminResolved

Associated revisions

Revision 8168ab17
Added by Lucas Di Pentima 5 months ago

Merge branch '15496-wb1-group-membership-admin'
Closes #15496

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

Revision 3fececec (diff)
Added by Lucas Di Pentima about 1 month ago

Merge branch '15496-wb1-group-membership-admin'
Closes #15496

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

Revision 7e5219ea (diff)
Added by Lucas Di Pentima about 1 month ago

Merge branch '15496-wb1-group-membership-admin'
Closes #15496

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

History

#1 Updated by Lucas Di Pentima 5 months ago

Comparing versions 1.3.3 against 1.4 or master, seems that rails' check_box_tag() template function is ignoring attributes with values being nil, in this case when a checkbox is rendered unchecked, its data-permission-uuid attribute should have "null" as its value, but it isn't there and the javascript click handler returns with the observed error message.

#2 Updated by Lucas Di Pentima 5 months ago

Updates at 431f22982 - branch 15496-wb1-group-membership-admin
Test run: https://ci.curoverse.com/job/developer-run-tests/1431/

Sets up a default 'x' value on data-permission-uuid instead of relying on rails' tag helper that from rails 5.0 seems to ignore attributes with falsy values.
As we have been having flakyness with the wb1's integration test suite, didn't think it's a good time investment to write a test for this as we're phasing workbench1, but I can do it if necessary.

#3 Updated by Lucas Di Pentima 5 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

#4 Updated by Tom Morris 4 months ago

  • Release set to 26

#5 Updated by Ward Vandewege 2 months ago

  • Release changed from 26 to 27

This was missed on the 1.4.1 release, the commit 431f22982dfee8f4d1c9590b3bce8d36709d5dd9 was not picked onto the 1.4-dev branch prior to the 1.4.1 release.

Also available in: Atom PDF