Arvados

Changes at arvados-workbench2|b114600c55e53b4c16f091edbabdb2ebeba0f032
Tests developer-tests-workbench2: #1054

• Added start button to process details card for uncommitted/draft processes
• Remove old re-run context menu item (leads to the 3 step launch workflow form)
• Rename process copy context menu item to "Copy and re-run process", since the copy action already puts the copied process into draft status
• I skipped pre-filling the copy destination because the tree picker doesn't seem to display the location when the copy form is initialized with a value

Stephen Smith wrote in #note-20:

Changes at arvados-workbench2|b114600c55e53b4c16f091edbabdb2ebeba0f032
Tests developer-tests-workbench2: #1054

• The run button as just a "play button" is a little bit subtle, I didn't notice it at first. I suggest giving Sarah a screenshot and see what she thinks.
• The "copy" dialog is small and awkward to use. It needs to be resized the same way we did with the file picker.
• Processes in "draft" state show incorrect contents in the Subprocesses panel, I we should go ahead and fix #19898 on this ticket.
• I'm looking at src/store/processes/process-copy-actions.ts and I'm not 100% sure the list of fields is correct. From our API docs, here's the fields that should be copied:
  • name
  • description
  • properties
  • container_count_max
  • mounts
  • runtime_constraints
  • scheduling_parameters
  • container_image
  • environment
  • cwd
  • command
  • output_path
  • output_name
  • output_ttl
  • use_existing
  • output_storage_classes
  • output_properties

In addition, state should be "Uncommitted" and priority should be 500.

Changes at arvados-workbench2|56529b81cf7b67cfea510652f07e1778cc82922e
Tests developer-tests-workbench2: #1063

• Fix incorrect subprocesses in subprocess panel
• Increase default height for tree picker
• Correct list of copied process properties
  • Adds description, output properties, and output storage classes
  • Removes expires at, filters, and requesting container uuid
• Set priority to 500 when copying
• Restyle run button to green contained button with label "Run Process" as suggested by Sarah

Some comments:

• The "RUN PROCESS" button doesn't have its label centered vertically, and being placed besides the "Draft" label makes it more evident.
• I think the "Copy & re-run process" action should navigate to the newly created process.
• I believe some additional testing is in order.
  • At least I imagine a unit test that exercises the "copy & re-run" action should be fairly easy (making sure all the correct params are copied, and state & priority correctly passed)
  • Testing that the "Run process" button appears when it should on Cypress would be another idea.

Changes at arvados-workbench2|79f55f622c5addb5351c9cc4d5976cf936fb7143
Tests developer-tests-workbench2: #1068

• Navigates to new process after copying
• Added unit test for copy process to verify which fields are copied
• Add cypress test that copies a process and checks for run process button

This LGTM, thanks!