https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422019-08-20T13:53:30ZArvadosArvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=770212019-08-20T13:53:30ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=770222019-08-20T14:30:57ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/77022/diff?detail_id=73700">diff</a>)</li></ul> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=770712019-08-20T19:30:07ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Assigned To</strong> set to <i>Peter Amstutz</i></li></ul> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=770872019-08-21T13:36:29ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Has duplicate</strong> <i><a class="issue tracker-6 status-7 priority-4 priority-default closed" href="/issues/15477">Idea #15477</a>: Use email address for Arvados account linking</i> added</li></ul> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=770892019-08-21T13:40:00ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Has duplicate</strong> <i><a class="issue tracker-6 status-7 priority-4 priority-default closed" href="/issues/15493">Idea #15493</a>: Allow admin to configure Unix account id</i> added</li></ul> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=771972019-08-22T15:31:32ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-6 status-3 priority-4 priority-default closed parent" href="/issues/15529">Idea #15529</a>: [API] [Controller] Share user account database with a group of trusted clusters</i> added</li></ul> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=771982019-08-22T15:32:21ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>15558-alternate-email-addresses @ <a class="changeset" title="15558: Add tests for user lookup by alternate email Arvados-DCO-1.1-Signed-off-by: Peter Amstutz..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/5713754c574254f9e3650ac80bf8fdca235898f6">5713754c574254f9e3650ac80bf8fdca235898f6</a></p>
<p><a class="external" href="https://ci.curoverse.com/view/Developer/job/developer-run-tests/1488/">https://ci.curoverse.com/view/Developer/job/developer-run-tests/1488/</a></p> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=773022019-08-28T14:41:11ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Target version</strong> changed from <i>2019-08-28 Sprint</i> to <i>2019-09-11 Sprint</i></li></ul> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=773332019-08-29T20:04:14ZEric Biagiotti
<ul></ul><p>Peter Amstutz wrote:</p>
<blockquote>
<p>15558-alternate-email-addresses @ <a class="changeset" title="15558: Add tests for user lookup by alternate email Arvados-DCO-1.1-Signed-off-by: Peter Amstutz..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/5713754c574254f9e3650ac80bf8fdca235898f6">5713754c574254f9e3650ac80bf8fdca235898f6</a></p>
<p><a class="external" href="https://ci.curoverse.com/view/Developer/job/developer-run-tests/1488/">https://ci.curoverse.com/view/Developer/job/developer-run-tests/1488/</a></p>
</blockquote>
<p><strong>SSO</strong>:</p>
<p>This LGTM</p>
<p><strong>API</strong>:</p>
<ul>
<li>You have a broken test. Looks like the stub content needs to be updated.</li>
</ul>
<pre>RemoteUsersTest#test_remote_user_inactive_without_pre-activation [/usr/src/arvados/services/api/test/integration/remote_user_test.rb:318]:
Expected false to be nil.
</pre>
<ul>
<li>services/api/app/models/user.rb line 405. The two entries in the first clause should both be <code>primary_user.email</code> right? Maybe tweak "fail lookup without identifiers" test to cover this?</li>
</ul>
<pre>if (!primary_user.email or primary_user.identity_url.empty?) and (!primary_user.identity_url or primary_user.identity_url.empty?)</pre>
<ul>
<li>What about the read-only and uniqueness changes from the description and the paragraph about handling if more than one address matched? If these are no longer needed, please update the description.</li>
</ul> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=773672019-09-04T20:18:37ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Eric Biagiotti wrote:</p>
<blockquote>
<p><strong>SSO</strong>:</p>
<p>This LGTM</p>
</blockquote>
<p>Thanks. I added a comment about the configuration option and merged it.</p>
<blockquote>
<p><strong>API</strong>:</p>
<ul>
<li>You have a broken test. Looks like the stub content needs to be updated.</li>
</ul>
</blockquote>
<p>Fixed. Unfortunately the "is_admin" field defaults to NULL (or nil) if not set explicitly.</p>
<blockquote>
<ul>
<li>services/api/app/models/user.rb line 405. The two entries in the first clause should both be <code>primary_user.email</code> right? Maybe tweak "fail lookup without identifiers" test to cover this?</li>
</ul>
</blockquote>
<p>Fixed. As it happens, if email is "" and identity_url is nil this would still raise an exception, but then it would be "method empty? not found on nil" instead of the intended one.</p>
<blockquote>
<ul>
<li>What about the read-only and uniqueness changes from the description and the paragraph about handling if more than one address matched? If these are no longer needed, please update the description.</li>
</ul>
</blockquote>
<p>I overlooked that, thanks. Implemented, with tests.</p>
<p>15558-alternate-email-addresses @ <a class="changeset" title="Merge branch 'master' into 15558-alternate-email-addresses Arvados-DCO-1.1-Signed-off-by: Peter ..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/d6c4fc82452b6c8e7fe492a0e2a163a19477f95a">d6c4fc82452b6c8e7fe492a0e2a163a19477f95a</a></p>
<p><a class="external" href="https://ci.curoverse.com/view/Developer/job/developer-run-tests/1495/">https://ci.curoverse.com/view/Developer/job/developer-run-tests/1495/</a></p> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=773742019-09-05T14:50:02ZEric Biagiotti
<ul></ul><p>Thanks for the updates. Just a few more things:</p>
<ul>
<li>RemoteUserTest.rb, line 297 has some debug output. </li>
<li>The description mentions updating the database to enforce identity_url uniqueness. Probably worth doing while we are working on it.</li>
</ul> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=773762019-09-05T15:25:24ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Eric Biagiotti wrote:</p>
<blockquote>
<p>Thanks for the updates. Just a few more things:</p>
<ul>
<li>RemoteUserTest.rb, line 297 has some debug output.</li>
</ul>
</blockquote>
<p>Fixed.</p>
<blockquote>
<ul>
<li>The description mentions updating the database to enforce identity_url uniqueness. Probably worth doing while we are working on it.</li>
</ul>
</blockquote>
<p>Thanks, I added a migration to do that.</p>
<p>15558-alternate-email-addresses @ <a class="changeset" title="15558: Enforce uniqueness on identity_url Exactly one user record can have a given identity_url...." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/9902ba33a4006d8652e675f76b6d7e43a2446d14">9902ba33a4006d8652e675f76b6d7e43a2446d14</a></p>
<p><a class="external" href="https://ci.curoverse.com/view/Developer/job/developer-run-tests/1498/">https://ci.curoverse.com/view/Developer/job/developer-run-tests/1498/</a></p> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=773772019-09-05T15:31:46ZEric Biagiotti
<ul></ul><p>Thanks, given the tests pass, this LGTM!</p> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=773812019-09-05T16:23:18ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Eric Biagiotti wrote:</p>
<blockquote>
<p>Thanks, given the tests pass, this LGTM!</p>
</blockquote>
<p><a class="external" href="https://ci.curoverse.com/view/Developer/job/developer-run-tests/1500/">https://ci.curoverse.com/view/Developer/job/developer-run-tests/1500/</a></p> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=773892019-09-05T18:28:05ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> deleted (<del><i>2019-09-11 Sprint</i></del>)</li></ul><p>15558-alternate-email-addresses @ 2fd0a7680e075431baa61288f34bf400ccaae849</p>
<p><a class="external" href="https://ci.curoverse.com/view/Developer/job/developer-run-tests/1503/">https://ci.curoverse.com/view/Developer/job/developer-run-tests/1503/</a></p> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=773962019-09-05T19:06:36ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>15558-alternate-email-addresses @ <a class="changeset" title="15558: Fix tests Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <pamstutz@veritasgenetics.com>" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/168c5a9a50b93f736b15b7a6c56af900b90aab39">168c5a9a50b93f736b15b7a6c56af900b90aab39</a></p>
<p><a class="external" href="https://ci.curoverse.com/view/Developer/job/developer-run-tests/1506/">https://ci.curoverse.com/view/Developer/job/developer-run-tests/1506/</a></p> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=774022019-09-05T20:42:31ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Target version</strong> set to <i>2019-09-11 Sprint</i></li></ul> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=774412019-09-10T14:19:37ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul> Arvados - Idea #15558: [SSO] [API] Identify users by (alternate) email addresseshttps://dev.arvados.org/issues/15558?journal_id=810832020-01-21T21:19:55ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Release</strong> set to <i>22</i></li></ul>