Project

General

Profile

Actions

Bug #15609

closed

Clicking outside popup dialog dismisses it

Added by Tom Morris about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Eric Biagiotti
Category:
-
Start date:
10/03/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

When creating a new project or doing any other action which uses a popup dialog to collection information, clicking outside of the popup modal (on the greyed out background), dismisses the popup, losing all information which has been collected.

The popup should only be dismissed when the Cancel button is clicked explicitly (and even then, it should probably ask for confirmation if some of the fields have already been filled in).


Subtasks 1 (0 open1 closed)

Arvados - Task #15663: Review 15609-popup-dialog-dismissalResolvedEric Biagiotti10/03/2019

Actions
Actions #1

Updated by Tom Morris about 3 years ago

  • Target version set to 2019-10-09 Sprint
Actions #2

Updated by Tom Morris about 3 years ago

  • Assigned To set to Eric Biagiotti
Actions #3

Updated by Eric Biagiotti about 3 years ago

  • Status changed from New to In Progress
Actions #4

Updated by Eric Biagiotti about 3 years ago

Latest in WB2 repo at 3b4fdda0f34dce6b213505cf54b1614bf3f94bb8

- Disables closing form dialogs via backdrop click or escape key. As discussed with Tom Morris, this does not include a cancel confirmation when fields have been partially filled.

Actions #5

Updated by Peter Amstutz about 3 years ago

Disabling the "click on background to dismiss" behavior LGTM.

From chat, I think it should still be possible to use the escape key to cancel a dialog, it is much less likely that someone would hit it by accident.

Actions #6

Updated by Eric Biagiotti about 3 years ago

Rebased to exclude blocking the escape key from dismissing the dialog @ bd1f778b16ab0bc2219c1314880ad4be6452a22c

Actions #7

Updated by Eric Biagiotti about 3 years ago

  • Status changed from In Progress to Resolved
  • Release set to 27
Actions

Also available in: Atom PDF