Bug #15609

Clicking outside popup dialog dismisses it

Added by Tom Morris about 1 month ago. Updated 15 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Start date:
10/03/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

When creating a new project or doing any other action which uses a popup dialog to collection information, clicking outside of the popup modal (on the greyed out background), dismisses the popup, losing all information which has been collected.

The popup should only be dismissed when the Cancel button is clicked explicitly (and even then, it should probably ask for confirmation if some of the fields have already been filled in).


Subtasks

Arvados - Task #15663: Review 15609-popup-dialog-dismissalResolvedEric Biagiotti

Associated revisions

Revision 5f77228e
Added by Eric Biagiotti 19 days ago

Merge branch '15609-popup-dialog-dismissal'

refs #15609

Arvados-DCO-1.1-Signed-off-by: Eric Biagiotti <>

History

#1 Updated by Tom Morris about 1 month ago

  • Target version set to 2019-10-09 Sprint

#2 Updated by Tom Morris 28 days ago

  • Assigned To set to Eric Biagiotti

#3 Updated by Eric Biagiotti 22 days ago

  • Status changed from New to In Progress

#4 Updated by Eric Biagiotti 20 days ago

Latest in WB2 repo at 3b4fdda0f34dce6b213505cf54b1614bf3f94bb8

- Disables closing form dialogs via backdrop click or escape key. As discussed with Tom Morris, this does not include a cancel confirmation when fields have been partially filled.

#5 Updated by Peter Amstutz 19 days ago

Disabling the "click on background to dismiss" behavior LGTM.

From chat, I think it should still be possible to use the escape key to cancel a dialog, it is much less likely that someone would hit it by accident.

#6 Updated by Eric Biagiotti 19 days ago

Rebased to exclude blocking the escape key from dismissing the dialog @ bd1f778b16ab0bc2219c1314880ad4be6452a22c

#7 Updated by Eric Biagiotti 19 days ago

  • Release set to 27
  • Status changed from In Progress to Resolved

Also available in: Atom PDF