Project

General

Profile

Actions

Bug #15640

closed

[CWL] some tests failing with "jshint failed to run succesfully"

Added by Peter Amstutz almost 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
10/04/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto


Subtasks 1 (0 open1 closed)

Task #15682: Review 15640-cwl-min-ramResolvedPeter Amstutz10/04/2019

Actions

Related issues

Related to Arvados - Bug #15692: [CWL] test_with_arvbox integration tests use tests inside imageNew

Actions
Actions #1

Updated by Peter Amstutz almost 3 years ago

  • Subject changed from some CWL tests failing with "jshint failed to run succesfully" to [CWL] some tests failing with "jshint failed to run succesfully"
  • Description updated (diff)
Actions #2

Updated by Peter Amstutz almost 3 years ago

  • Target version changed from 2019-09-25 Sprint to 2019-10-09 Sprint
Actions #3

Updated by Peter Amstutz almost 3 years ago

  • Assigned To set to Peter Amstutz
Actions #4

Updated by Peter Amstutz almost 3 years ago

  • Status changed from New to In Progress

Adjusted the memory assigned to the tests, they seem to be passing now.

A couple of takeaways

  • It seems that jobs that use RunInSingleContainer need to have a minimum of ~128 MiB RAM assigned to ensure that cwltool and jshint can run, it might be a good idea to set a floor.
  • The arvados-cwl-conformance-tests might be running tests from master instead of the provided githash, which would explain why my experiments didn't work, it wasn't running the modified test
Actions #5

Updated by Peter Amstutz almost 3 years ago

15640-cwl-min-ram @ 861599984cc86e100bd1c6dc36500a6f2334052d

- RunInSingleContainer sets minimum RAM at 128 MiB

With less than 128 MiB, jshint (which is invoked by cwltool) crashes, so set a floor on the RAM request.

Actions #6

Updated by Eric Biagiotti almost 3 years ago

Any chance job_res_reqs won't have an entry for "ramMin"? If true, there should be a check that get doesn't return None.

Nevermind, I see that it gets added in get_overall_res_req via max_res_pars.

Other than that, this LGTM. Thanks!

Actions #7

Updated by Peter Amstutz almost 3 years ago

  • Related to Bug #15692: [CWL] test_with_arvbox integration tests use tests inside image added
Actions #8

Updated by Peter Amstutz almost 3 years ago

  • Status changed from In Progress to Resolved
Actions #9

Updated by Peter Amstutz over 2 years ago

  • Release set to 22
Actions

Also available in: Atom PDF