Bug #15656

[API] container requests can have broken references to containers

Added by Peter Amstutz 4 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Tom Clegg
Category:
-
Target version:
2019-10-09 Sprint
Start date:
09/30/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release:
Arvados 1.4.2
Release relationship:
Auto

Description

The database does not enforce foreign key consistency on the container_uuid column. It is possible to delete a container that has container requests referring to it. If a container request has a reference to a container record that no longer exists, clients such as workbench break badly.

Related, it is intended that normal (non-admin) users cannot delete container records, but that may be missing a permission check.

Subtasks

Task #15675: Review 15656-user-delete-containerResolvedTom Clegg

Associated revisions

Revision dc491966
Added by Tom Clegg 4 months ago

Merge branch '15656-user-delete-container'

refs #15656

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

Revision 3f1b10bb (diff)
Added by Tom Clegg 2 months ago

Merge branch '15656-user-delete-container'

refs #15656

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

Revision dd49fd39 (diff)
Added by Tom Clegg 2 months ago

Merge branch '15656-user-delete-container'

refs #15656

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

History

#1 Updated by Peter Amstutz 4 months ago

  • Status changed from New to In Progress

#2 Updated by Peter Amstutz 4 months ago

  • Description updated (diff)

#3 Updated by Peter Amstutz 4 months ago

  • Status changed from In Progress to New

#6 Updated by Tom Clegg 4 months ago

  • Status changed from New to In Progress
  • Assigned To set to Tom Clegg
  • Target version changed from To Be Groomed to 2019-10-09 Sprint

#7 Updated by Eric Biagiotti 4 months ago

Other than that, this LGTM.

#8 Updated by Tom Clegg 4 months ago

15656-user-delete-container @ d22da8c4ae59fa50bfecaf3c5857fe8c0cc5fae7

"This API requires admin privileges. In normal operation, it should not be used at all. API clients like Workbench might not work correctly when a container request references a container that has been deleted."

#9 Updated by Tom Morris 4 months ago

  • Release set to 27

#10 Updated by Tom Clegg 3 months ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF