Feature #15669
closed
[Advanced Search] Search parameters in URL
Description
Currently the Search executes without the search criteria encoded in the URL. This has the disadvantage that searches can't be bookmarked or send to colleagues.
We would propose that search criteria are encoded in the url.
e.g. https://wb2.ardev.roche.com/search-results?criteria=has%3A%22Species%20or%20Strain%22%3A%22A%20Strains%22%20type%3Aarvados%23group
(to search for all projects that have a certain property set)
Updated by
Updated by Tom Morris about 5 years ago
- Target version changed from Workbench2 Q3, Q4 to To Be Groomed
Updated by Tom Morris about 5 years ago
- Target version changed from To Be Groomed to Arvados Future Sprints
Updated by Peter Amstutz about 5 years ago
- Assigned To set to Peter Amstutz
- Target version changed from Arvados Future Sprints to 2019-11-06 Sprint
Updated by Peter Amstutz about 5 years ago
- Status changed from New to In Progress
Updated by Peter Amstutz about 5 years ago
15669-search-params @ fb9e1c37cd3686f71140763202208dea17d7cd73 (workbench2 repo)
- navigateToSearchResults() adds the query parameter to the URI
- loadSearchResultsPanel() reads it from the URI
Updated by Lucas Di Pentima about 5 years ago
- Have you considered a way to test this new behavior? Otherwise LGTM.
- Found a bug while playing with the advanced search editor: if the user selects more than once any item on either “cluster”, “type” or “project” criteria, those get added to the search query instead of just using the last one selected.
Updated by Peter Amstutz about 5 years ago
Lucas Di Pentima wrote:
- Have you considered a way to test this new behavior? Otherwise LGTM.
Since it primarily interacts with routing, I don't think we can write tests for it until we put a test framework in place that can do whole-application testing.
- Found a bug while playing with the advanced search editor: if the user selects more than once any item on either “cluster”, “type” or “project” criteria, those get added to the search query instead of just using the last one selected.
Yea I noticed that too, that should get its own bug.
Updated by Lucas Di Pentima about 5 years ago
I've just created #15774 for the advanced search bug. The rest LGTM, please merge. Thanks!
Updated by Peter Amstutz about 5 years ago
- Status changed from In Progress to Resolved