Project

General

Profile

Actions

Feature #15669

closed

[Advanced Search] Search parameters in URL

Added by Moritz Gilsdorf over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Story points:
2.0

Description

Currently the Search executes without the search criteria encoded in the URL. This has the disadvantage that searches can't be bookmarked or send to colleagues.

We would propose that search criteria are encoded in the url.

e.g. https://wb2.ardev.roche.com/search-results?criteria=has%3A%22Species%20or%20Strain%22%3A%22A%20Strains%22%20type%3Aarvados%23group
(to search for all projects that have a certain property set)


Subtasks 1 (0 open1 closed)

Arvados - Task #15752: Review 15669-search-paramsResolvedPeter Amstutz10/29/2019Actions
Actions #1

Updated by Moritz Gilsdorf over 4 years ago

  • Description updated (diff)
Actions #2

Updated by Tom Morris over 4 years ago

  • Target version changed from Workbench2 Q3, Q4 to To Be Groomed
Actions #3

Updated by Tom Morris over 4 years ago

  • Story points set to 2.0
Actions #4

Updated by Tom Morris over 4 years ago

  • Target version changed from To Be Groomed to Arvados Future Sprints
Actions #5

Updated by Peter Amstutz over 4 years ago

  • Assigned To set to Peter Amstutz
  • Target version changed from Arvados Future Sprints to 2019-11-06 Sprint
Actions #6

Updated by Peter Amstutz over 4 years ago

  • Status changed from New to In Progress
Actions #7

Updated by Peter Amstutz over 4 years ago

15669-search-params @ fb9e1c37cd3686f71140763202208dea17d7cd73 (workbench2 repo)

  1. navigateToSearchResults() adds the query parameter to the URI
  2. loadSearchResultsPanel() reads it from the URI
Actions #8

Updated by Lucas Di Pentima over 4 years ago

  • Have you considered a way to test this new behavior? Otherwise LGTM.
  • Found a bug while playing with the advanced search editor: if the user selects more than once any item on either “cluster”, “type” or “project” criteria, those get added to the search query instead of just using the last one selected.
Actions #9

Updated by Peter Amstutz over 4 years ago

Lucas Di Pentima wrote:

  • Have you considered a way to test this new behavior? Otherwise LGTM.

Since it primarily interacts with routing, I don't think we can write tests for it until we put a test framework in place that can do whole-application testing.

  • Found a bug while playing with the advanced search editor: if the user selects more than once any item on either “cluster”, “type” or “project” criteria, those get added to the search query instead of just using the last one selected.

Yea I noticed that too, that should get its own bug.

Actions #10

Updated by Lucas Di Pentima over 4 years ago

I've just created #15774 for the advanced search bug. The rest LGTM, please merge. Thanks!

Actions #11

Updated by Peter Amstutz over 4 years ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF