Feature #15669

[Advanced Search] Search parameters in URL

Added by Moritz Gilsdorf 10 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Start date:
10/29/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
2.0

Description

Currently the Search executes without the search criteria encoded in the URL. This has the disadvantage that searches can't be bookmarked or send to colleagues.

We would propose that search criteria are encoded in the url.

e.g. https://wb2.ardev.roche.com/search-results?criteria=has%3A%22Species%20or%20Strain%22%3A%22A%20Strains%22%20type%3Aarvados%23group
(to search for all projects that have a certain property set)


Subtasks

Arvados - Task #15752: Review 15669-search-paramsResolvedPeter Amstutz

Associated revisions

Revision 88fc1bb0
Added by Peter Amstutz 9 months ago

Merge branch '15669-search-params' refs #15669

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

History

#1 Updated by Moritz Gilsdorf 10 months ago

  • Description updated (diff)

#2 Updated by Tom Morris 10 months ago

  • Target version changed from Workbench2 Q3, Q4 to To Be Groomed

#3 Updated by Tom Morris 10 months ago

  • Story points set to 2.0

#4 Updated by Tom Morris 10 months ago

  • Target version changed from To Be Groomed to Arvados Future Sprints

#5 Updated by Peter Amstutz 10 months ago

  • Assigned To set to Peter Amstutz
  • Target version changed from Arvados Future Sprints to 2019-11-06 Sprint

#6 Updated by Peter Amstutz 9 months ago

  • Status changed from New to In Progress

#7 Updated by Peter Amstutz 9 months ago

15669-search-params @ fb9e1c37cd3686f71140763202208dea17d7cd73 (workbench2 repo)

  1. navigateToSearchResults() adds the query parameter to the URI
  2. loadSearchResultsPanel() reads it from the URI

#8 Updated by Lucas Di Pentima 9 months ago

  • Have you considered a way to test this new behavior? Otherwise LGTM.
  • Found a bug while playing with the advanced search editor: if the user selects more than once any item on either “cluster”, “type” or “project” criteria, those get added to the search query instead of just using the last one selected.

#9 Updated by Peter Amstutz 9 months ago

Lucas Di Pentima wrote:

  • Have you considered a way to test this new behavior? Otherwise LGTM.

Since it primarily interacts with routing, I don't think we can write tests for it until we put a test framework in place that can do whole-application testing.

  • Found a bug while playing with the advanced search editor: if the user selects more than once any item on either “cluster”, “type” or “project” criteria, those get added to the search query instead of just using the last one selected.

Yea I noticed that too, that should get its own bug.

#10 Updated by Lucas Di Pentima 9 months ago

I've just created #15774 for the advanced search bug. The rest LGTM, please merge. Thanks!

#11 Updated by Peter Amstutz 9 months ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF