Arvados » Arvados Workbench 2

15669-search-params @ fb9e1c37cd3686f71140763202208dea17d7cd73 (workbench2 repo)

1. navigateToSearchResults() adds the query parameter to the URI
2. loadSearchResultsPanel() reads it from the URI

• Have you considered a way to test this new behavior? Otherwise LGTM.
• Found a bug while playing with the advanced search editor: if the user selects more than once any item on either “cluster”, “type” or “project” criteria, those get added to the search query instead of just using the last one selected.

Lucas Di Pentima wrote:

• Have you considered a way to test this new behavior? Otherwise LGTM.

Since it primarily interacts with routing, I don't think we can write tests for it until we put a test framework in place that can do whole-application testing.

• Found a bug while playing with the advanced search editor: if the user selects more than once any item on either “cluster”, “type” or “project” criteria, those get added to the search query instead of just using the last one selected.

Yea I noticed that too, that should get its own bug.

I've just created #15774 for the advanced search bug. The rest LGTM, please merge. Thanks!