Story #15800

Update 1.4-dev branch with cherry picked bugs for 1.4.2

Added by Tom Morris 8 months ago. Updated 8 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
11/07/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
1.0

Description


Subtasks

Task #15805: Review 15800-arvados-1-4-2 (arvados repo) & arvados-1-4-2 (wb2 repo)ResolvedPeter Amstutz

History

#1 Updated by Tom Morris 8 months ago

  • Assigned To set to Lucas Di Pentima
  • Story points set to 1.0

#2 Updated by Lucas Di Pentima 8 months ago

  • Status changed from New to In Progress

#3 Updated by Lucas Di Pentima 8 months ago

Updates at bd6922e - branch 15800-arvados-1-4-2 (arvados repo)
Test run: https://ci.curoverse.com/job/developer-run-tests/1630/
PySDK tests retry: https://ci.curoverse.com/job/developer-run-tests-sdk-python-ruby/921/
WB functional tests retry: https://ci.curoverse.com/job/developer-run-tests-apps-workbench-functionals/1657/

  • #15496: [Workbench] Group membership doesn't work on User admin page
    • git cherry-pick -m 1 8168ab173ff7a09d25e1838732e4fbafee88df98
  • #15361: [acr] --create-workflow failures
    • It depends on #15028 (planned for 1.5) - skipping
  • #15655: [CWL] encoding error when printing error log tail
    • git cherry-pick -m 1 a169f9f
  • #15656: [API] container requests can have broken references to containers
    • git cherry-pick -m 1 dc49196
  • #15699: [Workbench] Data corruption creating a new collection
    • git cherry-pick -m 1 0099f77
    • git cherry-pick 1c2c0ee7
    • git cherry-pick dd9f2403
    • git cherry-pick -m 1 703356a
    • git cherry-pick -m 1 76d2857
  • #15652: crunch-run killed after spike in RAM usage during upload after container completes
    • git cherry-pick -m 1 cc8174a
  • #15680: arv-put possibly not retrying by default
    • git cherry-pick -m 1 6f779a6b
  • #15716: [api] deleting all keep_service records results in 422 error on subsequent request for keep_service list
    • It fixes an issue introduced on #15311 (planned for 1.5) - skipping
  • #15793: [workbench] [performance] [qr1hi] >500s of delay on groups page
    • git cherry-pick -m 1 4fdda0b
  • #15497: [ACR] arv:ReuseRequirement question possible bug (?)
    • git cherry-pick -m 1 aa4b9b1

Pending: workbench2 repo

#4 Updated by Lucas Di Pentima 8 months ago

As requested by Peter, rebased the 1.4-dev branch to drop a couple of commits pinning the faraday gem version on different .gemspec files.

Updates at 0e0b561 - branch 15800-arvados-1-4-2 (which now has this new 1.4-dev's HEAD commit as a parent)
Test run: https://ci.curoverse.com/job/developer-run-tests/1632/
WB integration re-try: https://ci.curoverse.com/job/developer-run-tests-apps-workbench-integration/1728/

#5 Updated by Lucas Di Pentima 8 months ago

WB2 repo: updates at commit 1c02690 - branch arvados-1-4-2

  • #15407: [WB2] Property keys on collections are getting translated from snake_case to camelCase
    • git cherry-pick -m 1 0aea0fe
  • #15027: [WB2] [Data operations] Error attempting to set read-only attributes
    • git cherry-pick 24e864bc823b27ac27c39e9e5879987924330007 (from #14874 but needed for the next cherry-pick)
    • git cherry-pick -m 1 02fe86a5
  • #15524: [WB2] No human readable name for anonymous sharing
    • git cherry-pick -m 1 54e00d0
  • #15609: Clicking outside popup dialog dismisses it
    • git cherry-pick -m 1 5f77228e

#6 Updated by Peter Amstutz 8 months ago

I don't see #15716 or #15361 in the branch.

Sorry didn't read the note above. Those should be removed from https://dev.arvados.org/rb/release/27 to avoid confusion.

The rest looks good!

#7 Updated by Lucas Di Pentima 8 months ago

Check https://dev.arvados.org/issues/15800#note-3, those 2 were skipped, it's explained why.

#8 Updated by Lucas Di Pentima 8 months ago

Peter Amstutz wrote:

Sorry didn't read the note above. Those should be removed from https://dev.arvados.org/rb/release/27 to avoid confusion.

Done! Now I'm trying to see if the arvbox issue I'm seeing is only local to my machine before merging those branches to 1.4-dev and tagging it with 1.4.2.

#9 Updated by Lucas Di Pentima 8 months ago

Was able to run arvbox successfully after cleaning up my local environment.

Fast-forward merged the release branches to either 1.4-dev branches on both repos, and tag them with 1.4.2

#10 Updated by Lucas Di Pentima 8 months ago

Added a 1.4-dev branch with the corresponding 1.4.2 tag to the composer repository.

#11 Updated by Lucas Di Pentima 8 months ago

On sso-provider repo's 1.4-dev:

  • git cherry-pick -m 1 c8be990 (this was already released on 1.4.1 but wasn't included on the 1.4-dev branch)
  • tagged it with 1.4.2

#12 Updated by Lucas Di Pentima 8 months ago

  • Status changed from In Progress to Resolved

Created https://dev.arvados.org/issues/15816 for the new release.

Also available in: Atom PDF