[packages] workbench dev package not being built
It looks like something is wrong with the way we calculate version numbers for workbench dev packages.
Merge commit 522d525a4 included changes in apps/workbench, so it should have made a new package.
$ git l * 522d525a4 Merge branch '15799-baseurl-missing-slash' |\ | * 8f8a26674 15799: Ensure default baseURL has a trailing slash. * | b30dca66a Merge branch '15107-google-login' |\ \ | |/ |/| | * f2fe9d684 15107: Remove nonexistent legacy config key. $ TZ=UTC git log -n1 --first-parent apps/workbench commit 522d525a4dcbf11a22d14ea78a0c362272533c34 Merge: b30dca66a 8f8a26674 Author: Tom Clegg <firstname.lastname@example.org> Date: Wed Nov 6 16:17:03 2019 -0500
Build 1128 made a package for revision b30dca66a, but build 1129 chose not to make a package for 522d525a4:
b30dca66a056bc6ee627bab5956dd8884a0e74aa = Wed Nov 6 13:59:29 2019 -0500 https://ci.curoverse.com/job/build-packages-debian9/1128/consoleFull Checking out Revision b30dca66a056bc6ee627bab5956dd8884a0e74aa (detached) ... Package arvados-workbench_22.214.171.12491106185929-1_amd64.deb not found, building ... 522d525a4dcbf11a22d14ea78a0c362272533c34 = Wed Nov 6 16:17:03 2019 -0500 https://ci.curoverse.com/job/build-packages-debian9/1129/consoleFull Checking out Revision 522d525a4dcbf11a22d14ea78a0c362272533c34 (detached) ... Package arvados-workbench_126.96.36.19991106185929-1_amd64.deb exists upstream, not rebuilding, downloading instead!
Fix rails package versions for dev builds.
[ $goversion > $railsversion ] doesn't compare versions, it just
creates an empty file called $railsversion and returns success. As a
result, the arvados-api-server and arvados-workbench package
numbers (and the rebuild-or-reuse decisions) were based only on the
last change to cmd/arvados-server, disregarding more recent changes in
the respective Rails projects.
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <email@example.com>