Project

General

Profile

Actions

Feature #15828

closed

[API] Workbench is "trusted client" trusted by default

Added by Peter Amstutz almost 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
11/14/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Configured workbench endpoints should be "trusted clients" by default.


Subtasks 1 (0 open1 closed)

Task #15829: Review 15828-trust-wbResolvedPeter Amstutz11/14/2019

Actions
Actions #1

Updated by Peter Amstutz almost 3 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Peter Amstutz almost 3 years ago

  • Description updated (diff)
Actions #4

Updated by Peter Amstutz almost 3 years ago

15828-trust-wb @ acb8ea09b9d699bb5c955a5279a0aca2e0906c39

Override is_trusted so that it is always true for the configured external URL of workbench1 and workbench2.

Actions #5

Updated by Peter Amstutz almost 3 years ago

  • Assigned To set to Peter Amstutz
Actions #6

Updated by Tom Clegg almost 3 years ago

LGTM.

In order for this to work in practice we might need to mention Services.Workbench2.ExternalURL on https://doc.arvados.org/master/install/install-api-server.html (only Workbench1 is there).

The "Trusted client setting" sections should probably be deleted from https://doc.arvados.org/master/install/install-workbench-app.html and
https://doc.arvados.org/master/install/install-workbench2-app.html.

Actions #7

Updated by Peter Amstutz almost 3 years ago

Tom Clegg wrote:

LGTM.

In order for this to work in practice we might need to mention Services.Workbench2.ExternalURL on https://doc.arvados.org/master/install/install-api-server.html (only Workbench1 is there).

The "Trusted client setting" sections should probably be deleted from https://doc.arvados.org/master/install/install-workbench-app.html and
https://doc.arvados.org/master/install/install-workbench2-app.html.

Yep, I will be incorporating all that in #15572 . I desperately wanted to make sure this fix got in specifically because it would eliminate a very error-prone step from install process.

Actions #8

Updated by Peter Amstutz almost 3 years ago

  • Status changed from In Progress to Resolved
Actions #9

Updated by Peter Amstutz over 2 years ago

  • Release set to 22
Actions

Also available in: Atom PDF