Feature #15828

[API] Workbench is "trusted client" trusted by default

Added by Peter Amstutz 8 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
11/14/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Configured workbench endpoints should be "trusted clients" by default.


Subtasks

Task #15829: Review 15828-trust-wbResolvedPeter Amstutz

Associated revisions

Revision 89e13889
Added by Peter Amstutz 8 months ago

Merge branch '15828-trust-wb' refs #15828

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

History

#1 Updated by Peter Amstutz 8 months ago

  • Status changed from New to In Progress

#3 Updated by Peter Amstutz 8 months ago

  • Description updated (diff)

#4 Updated by Peter Amstutz 8 months ago

15828-trust-wb @ acb8ea09b9d699bb5c955a5279a0aca2e0906c39

Override is_trusted so that it is always true for the configured external URL of workbench1 and workbench2.

#5 Updated by Peter Amstutz 8 months ago

  • Assigned To set to Peter Amstutz

#6 Updated by Tom Clegg 8 months ago

LGTM.

In order for this to work in practice we might need to mention Services.Workbench2.ExternalURL on https://doc.arvados.org/master/install/install-api-server.html (only Workbench1 is there).

The "Trusted client setting" sections should probably be deleted from https://doc.arvados.org/master/install/install-workbench-app.html and
https://doc.arvados.org/master/install/install-workbench2-app.html.

#7 Updated by Peter Amstutz 8 months ago

Tom Clegg wrote:

LGTM.

In order for this to work in practice we might need to mention Services.Workbench2.ExternalURL on https://doc.arvados.org/master/install/install-api-server.html (only Workbench1 is there).

The "Trusted client setting" sections should probably be deleted from https://doc.arvados.org/master/install/install-workbench-app.html and
https://doc.arvados.org/master/install/install-workbench2-app.html.

Yep, I will be incorporating all that in #15572 . I desperately wanted to make sure this fix got in specifically because it would eliminate a very error-prone step from install process.

#8 Updated by Peter Amstutz 8 months ago

  • Status changed from In Progress to Resolved

#9 Updated by Peter Amstutz 6 months ago

  • Release set to 22

Also available in: Atom PDF