Bug #15848

[Workbench1] multi-site search does not display results

Added by Tom Clegg almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
-
Start date:
12/04/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

The "request in progress" indicator behaves as expected, and (according to the browser debugger) non-empty lists of collections/projects are retrieved successfully -- but none are displayed.

no-search-results.png (143 KB) no-search-results.png Tom Clegg, 11/20/2019 02:14 PM

Subtasks

Task #15860: ReviewClosedTom Clegg


Related issues

Related to Arvados - Story #15911: Integration tests for WB1 multi site search (mithril app)In Progress

Associated revisions

Revision 06c9ea02
Added by Tom Clegg almost 2 years ago

Merge branch '15848-controller-list-sort'

refs #15848

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

History

#1 Updated by Lucas Di Pentima almost 2 years ago

  • Assigned To set to Lucas Di Pentima

#2 Updated by Lucas Di Pentima almost 2 years ago

  • Status changed from New to In Progress

#3 Updated by Tom Clegg almost 2 years ago

CollectionList() in source:lib/controller/federation/list.go is incorrectly sorting list results by UUID regardless of client-supplied order param. Instead, it should:
  • sort by the usual default "modified_at desc" when merging results from multiple backends (which only happens when the client does not specify order)
  • don't sort the results when they come from a single backend, because in this case they're already sorted correctly

#5 Updated by Tom Clegg almost 2 years ago

installed arvados-controller 086c972bae004544cb43d9ea15388d486d3cd1ed-dev on 4xphq and restarted ... now results appear in wb1 multisite search

#6 Updated by Lucas Di Pentima almost 2 years ago

15848-controller-list-sort LGTM, thanks! I'll continue with the wb1 integration test on my branch, make sure it fails, and then merge (new) master to check that it stops failing.

#7 Updated by Lucas Di Pentima almost 2 years ago

  • Target version changed from 2019-12-04 Sprint to 2020-01-02 Sprint

#8 Updated by Lucas Di Pentima almost 2 years ago

  • Status changed from In Progress to Resolved

Marking as resolved: The original bug is fixed, there's a pending wb1 multi site integration test writing task that will be done on a separate ticket.

#9 Updated by Lucas Di Pentima almost 2 years ago

  • Related to Story #15911: Integration tests for WB1 multi site search (mithril app) added

#10 Updated by Tom Morris almost 2 years ago

  • Target version deleted (2020-01-02 Sprint)

#11 Updated by Peter Amstutz almost 2 years ago

  • Release set to 22

Also available in: Atom PDF