Project

General

Profile

Actions

Bug #15848

closed

[Workbench1] multi-site search does not display results

Added by Tom Clegg about 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
-
Story points:
-
Release relationship:
Auto

Description

The "request in progress" indicator behaves as expected, and (according to the browser debugger) non-empty lists of collections/projects are retrieved successfully -- but none are displayed.


Files

no-search-results.png (143 KB) no-search-results.png Tom Clegg, 11/20/2019 02:14 PM

Subtasks 1 (0 open1 closed)

Task #15860: ReviewClosedTom Clegg12/04/2019Actions

Related issues 1 (0 open1 closed)

Related to Arvados - Idea #15911: Integration tests for WB1 multi site search (mithril app)Closed01/11/2023Actions
Actions #1

Updated by Lucas Di Pentima about 5 years ago

  • Assigned To set to Lucas Di Pentima
Actions #2

Updated by Lucas Di Pentima about 5 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Tom Clegg about 5 years ago

CollectionList() in source:lib/controller/federation/list.go is incorrectly sorting list results by UUID regardless of client-supplied order param. Instead, it should:
  • sort by the usual default "modified_at desc" when merging results from multiple backends (which only happens when the client does not specify order)
  • don't sort the results when they come from a single backend, because in this case they're already sorted correctly
Actions #5

Updated by Tom Clegg about 5 years ago

installed arvados-controller 086c972bae004544cb43d9ea15388d486d3cd1ed-dev on 4xphq and restarted ... now results appear in wb1 multisite search

Actions #6

Updated by Lucas Di Pentima about 5 years ago

15848-controller-list-sort LGTM, thanks! I'll continue with the wb1 integration test on my branch, make sure it fails, and then merge (new) master to check that it stops failing.

Actions #7

Updated by Lucas Di Pentima about 5 years ago

  • Target version changed from 2019-12-04 Sprint to 2020-01-02 Sprint
Actions #8

Updated by Lucas Di Pentima about 5 years ago

  • Status changed from In Progress to Resolved

Marking as resolved: The original bug is fixed, there's a pending wb1 multi site integration test writing task that will be done on a separate ticket.

Actions #9

Updated by Lucas Di Pentima about 5 years ago

  • Related to Idea #15911: Integration tests for WB1 multi site search (mithril app) added
Actions #10

Updated by Tom Morris about 5 years ago

  • Target version deleted (2020-01-02 Sprint)
Actions #11

Updated by Peter Amstutz almost 5 years ago

  • Release set to 22
Actions

Also available in: Atom PDF