Arvados

Updates at 8e1ca7677 - branch 15849-vocab-migration-example

Adds vocabulary migration example script to the documentation's admin section with an explanation on how to use it.

You can use required=True instead of default=None and then checking the value later.

opts.add_argument('--vocabulary-file', type=str, metavar='PATH', default=None,

list_all should use a stable ordering, like "created_at"

I know I said to put the script into the docs, but it occurred to me that you could put it in tools/vocabulary_migrate/vocabulary_migrate.py and have a symlink from docs/_include/_vocabulary_migrate_py.liquid to ../../tools/vocabulary_migrate/vocabulary_migrate.py

The {% comment %} makes it not directly executable as Python. A regular '#' comment is fine.

The migration script tag / values label matching is case sensitive. I'm not quite sure what to do about it, thought I'd mention it.

Updates at c6b259220

Addressed above comments. Added a note on the documentation about case sensitive matching.

Lucas Di Pentima wrote:

Updates at c6b259220

Addressed above comments. Added a note on the documentation about case sensitive matching.

One more comment, if you do --dry-run and there is nothing to do, it exits silently, whereas an actual run will say "Done, total object migrated: 0"

• should be "objects"
• for dry-run it should say something like "nothing to do"

otherwise LGTM.

Fixed at b0f2bbde0, thanks!