Feature #15854

Add container request filtering based on container.exit_code and container.state

Added by Eric Biagiotti 7 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
API
Target version:
Start date:
11/20/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Update the container_requests list query API with special cases for container.exit_code and container.state


Subtasks

Task #15858: Review 15854-filter-container-fieldsResolvedEric Biagiotti


Related issues

Blocks Arvados Workbench 2 - Bug #15672: List of subprocesses limited in process viewResolved12/16/2019

Associated revisions

Revision c73f87c5
Added by Tom Clegg 7 months ago

Merge branch '15854-filter-container-fields'

closes #15854

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

History

#1 Updated by Eric Biagiotti 7 months ago

  • Blocks Bug #15672: List of subprocesses limited in process view added

#2 Updated by Tom Morris 7 months ago

  • Assigned To set to Tom Clegg

#3 Updated by Tom Clegg 7 months ago

  • Status changed from New to In Progress

15854-filter-container-fields @ 002aec2a7db39d269bb3c9123783022c2e32a5cc -- https://ci.curoverse.com/view/Developer/job/developer-run-tests/1659/

I removed the "see create method for Container[Request]-specific filters" comments from the API docs. They seem to have been copy-pasted from the Jobs API pages, and intended to refer to the "filters" attribute of jobs/container requests. On the "container requests" API page it was unhelpful (there's no mention of filters under the create method, and that topic has little to do with listing container requests); on the "containers" API page it was just an error (there is no "filters" field for a container record).

#4 Updated by Eric Biagiotti 7 months ago

Tom Clegg wrote:

15854-filter-container-fields @ 002aec2a7db39d269bb3c9123783022c2e32a5cc -- https://ci.curoverse.com/view/Developer/job/developer-run-tests/1659/

I removed the "see create method for Container[Request]-specific filters" comments from the API docs. They seem to have been copy-pasted from the Jobs API pages, and intended to refer to the "filters" attribute of jobs/container requests. On the "container requests" API page it was unhelpful (there's no mention of filters under the create method, and that topic has little to do with listing container requests); on the "containers" API page it was just an error (there is no "filters" field for a container record).

This LGTM! Did some manual testing using "arv container_request list" and it works great, thanks!

#5 Updated by Tom Clegg 7 months ago

  • Status changed from In Progress to Resolved

#6 Updated by Peter Amstutz 5 months ago

  • Release set to 22

#7 Updated by Stanislaw Adaszewski 2 months ago

Does it also allow to use container.state and container.exit_code in select? It would be great for populating lists of container requests.

Also available in: Atom PDF