Project

General

Profile

Actions

Feature #15854

closed

Add container request filtering based on container.exit_code and container.state

Added by Eric Biagiotti about 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
API
Target version:
Start date:
11/20/2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

Update the container_requests list query API with special cases for container.exit_code and container.state


Subtasks 1 (0 open1 closed)

Task #15858: Review 15854-filter-container-fieldsResolvedEric Biagiotti11/20/2019

Actions

Related issues

Blocks Arvados Workbench 2 - Bug #15672: List of subprocesses limited in process viewResolvedLucas Di Pentima12/16/2019

Actions
Actions #1

Updated by Eric Biagiotti about 3 years ago

  • Blocks Bug #15672: List of subprocesses limited in process view added
Actions #2

Updated by Tom Morris about 3 years ago

  • Assigned To set to Tom Clegg
Actions #3

Updated by Tom Clegg about 3 years ago

  • Status changed from New to In Progress

15854-filter-container-fields @ 002aec2a7db39d269bb3c9123783022c2e32a5cc -- https://ci.curoverse.com/view/Developer/job/developer-run-tests/1659/

I removed the "see create method for Container[Request]-specific filters" comments from the API docs. They seem to have been copy-pasted from the Jobs API pages, and intended to refer to the "filters" attribute of jobs/container requests. On the "container requests" API page it was unhelpful (there's no mention of filters under the create method, and that topic has little to do with listing container requests); on the "containers" API page it was just an error (there is no "filters" field for a container record).

Actions #4

Updated by Eric Biagiotti about 3 years ago

Tom Clegg wrote:

15854-filter-container-fields @ 002aec2a7db39d269bb3c9123783022c2e32a5cc -- https://ci.curoverse.com/view/Developer/job/developer-run-tests/1659/

I removed the "see create method for Container[Request]-specific filters" comments from the API docs. They seem to have been copy-pasted from the Jobs API pages, and intended to refer to the "filters" attribute of jobs/container requests. On the "container requests" API page it was unhelpful (there's no mention of filters under the create method, and that topic has little to do with listing container requests); on the "containers" API page it was just an error (there is no "filters" field for a container record).

This LGTM! Did some manual testing using "arv container_request list" and it works great, thanks!

Actions #5

Updated by Tom Clegg about 3 years ago

  • Status changed from In Progress to Resolved
Actions #6

Updated by Peter Amstutz about 3 years ago

  • Release set to 22
Actions #7

Updated by Stanislaw Adaszewski almost 3 years ago

Does it also allow to use container.state and container.exit_code in select? It would be great for populating lists of container requests.

Actions

Also available in: Atom PDF