Feature #15854
closed
Add container request filtering based on container.exit_code and container.state
Description
Update the container_requests list query API with special cases for container.exit_code and container.state
Related issues
Updated by Eric Biagiotti over 4 years ago
- Blocks Bug #15672: List of subprocesses limited in process view added
Updated by Tom Morris
Updated by Tom Clegg over 4 years ago
- Status changed from New to In Progress
15854-filter-container-fields @ 002aec2a7db39d269bb3c9123783022c2e32a5cc -- https://ci.curoverse.com/view/Developer/job/developer-run-tests/1659/
I removed the "see create method for Container[Request]-specific filters" comments from the API docs. They seem to have been copy-pasted from the Jobs API pages, and intended to refer to the "filters" attribute of jobs/container requests. On the "container requests" API page it was unhelpful (there's no mention of filters under the create method, and that topic has little to do with listing container requests); on the "containers" API page it was just an error (there is no "filters" field for a container record).
Updated by Eric Biagiotti over 4 years ago
Tom Clegg wrote:
15854-filter-container-fields @ 002aec2a7db39d269bb3c9123783022c2e32a5cc -- https://ci.curoverse.com/view/Developer/job/developer-run-tests/1659/
I removed the "see create method for Container[Request]-specific filters" comments from the API docs. They seem to have been copy-pasted from the Jobs API pages, and intended to refer to the "filters" attribute of jobs/container requests. On the "container requests" API page it was unhelpful (there's no mention of filters under the create method, and that topic has little to do with listing container requests); on the "containers" API page it was just an error (there is no "filters" field for a container record).
This LGTM! Did some manual testing using "arv container_request list" and it works great, thanks!
Updated by Tom Clegg over 4 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|c73f87c5fedba20b82a091152353f718d81ba6c3.
Updated by
Updated by Stanislaw Adaszewski about 4 years ago
Does it also allow to use container.state and container.exit_code in select? It would be great for populating lists of container requests.