Feature #15854: Add container request filtering based on container.exit_code and container.state - Arvados

Custom queries

All assigned issues
All issues assigned for grooming
My issues for grooming
My issues for grooming (no story pts)
Prioritized open issues

Actions

Copy link

Feature #15854

closed

Add container request filtering based on container.exit_code and container.state

Added by Eric Biagiotti over 5 years ago. Updated about 5 years ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Tom Clegg

Category:

API

Target version:

2019-12-04 Sprint

Story points:

Release:

Arvados 2.0 - Early 2020

Release relationship:

Auto

Description

Update the container_requests list query API with special cases for container.exit_code and container.state

Subtasks 1 (0 open — 1 closed)

Task #15858: Review 15854-filter-container-fields

Resolved

Eric Biagiotti

11/20/2019

Actions

Related issues 1 (0 open — 1 closed)

Blocks Arvados Workbench 2 - Bug #15672: List of subprocesses limited in process view

Resolved

Lucas Di Pentima

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Eric Biagiotti over 5 years ago

Blocks Bug #15672: List of subprocesses limited in process view added

Actions

Copy link

Updated by Tom Morris over 5 years ago

Assigned To set to Tom Clegg

Actions

Copy link

Updated by Tom Clegg over 5 years ago

Status changed from New to In Progress

15854-filter-container-fields @ 002aec2a7db39d269bb3c9123783022c2e32a5cc -- https://ci.curoverse.com/view/Developer/job/developer-run-tests/1659/

I removed the "see create method for Container[Request]-specific filters" comments from the API docs. They seem to have been copy-pasted from the Jobs API pages, and intended to refer to the "filters" attribute of jobs/container requests. On the "container requests" API page it was unhelpful (there's no mention of filters under the create method, and that topic has little to do with listing container requests); on the "containers" API page it was just an error (there is no "filters" field for a container record).

Actions

Copy link

Updated by Eric Biagiotti over 5 years ago

Tom Clegg wrote:

15854-filter-container-fields @ 002aec2a7db39d269bb3c9123783022c2e32a5cc -- https://ci.curoverse.com/view/Developer/job/developer-run-tests/1659/

I removed the "see create method for Container[Request]-specific filters" comments from the API docs. They seem to have been copy-pasted from the Jobs API pages, and intended to refer to the "filters" attribute of jobs/container requests. On the "container requests" API page it was unhelpful (there's no mention of filters under the create method, and that topic has little to do with listing container requests); on the "containers" API page it was just an error (there is no "filters" field for a container record).

This LGTM! Did some manual testing using "arv container_request list" and it works great, thanks!

Actions

Copy link